Find/Replace Overlay: correctly set scope mode #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wittmaxi
force-pushed
the
MW_line_separators
branch
from
666db2f to
88f1f62
Compare
|
random fail documented #1808 |
Wittmaxi
pushed a commit
to Wittmaxi/eclipse.platform.ui
that referenced
this pull request
Jul 8, 2024
Stores the search options of the overlay and actively reloads them, even when switching between overlays. fixes eclipse-platform#2057
HeikoKlare
force-pushed
the
MW_line_separators
branch
2 times, most recently
from
ec40478 to
9b7145a
Compare
Depending on the file format, the line separators are different. This PR allows detecting both when deciding whether to set the scoped search mode or not when opening the Overlay with an active selection. fixes eclipse-platform#2054
HeikoKlare
force-pushed
the
MW_line_separators
branch
from
9b7145a to
3153f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the file format, the line separators are different. This PR allows detecting both when deciding whether to set the scoped search mode or not when opening the Overlay with an active selection.
fixes #2054
To test: use a file formatted on UNIX (line separators: \n), select multiple lines, open overaly