Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find/Replace overlay: UNIX-line separators are not interpreted correctly on Windows #2054

Closed
Tracked by #2021
Wittmaxi opened this issue Jul 8, 2024 · 0 comments · Fixed by #2057
Closed
Tracked by #2021

Find/Replace overlay: UNIX-line separators are not interpreted correctly on Windows #2054

Wittmaxi opened this issue Jul 8, 2024 · 0 comments · Fixed by #2057
Labels
bug Something isn't working

Comments

@Wittmaxi
Copy link

Wittmaxi commented Jul 8, 2024

When selecting multiple lines in a file formatted for Unix, the selection is not interpreted as "search scope" as it should be
@Wittmaxi Wittmaxi added the bug Something isn't working label Jul 8, 2024
@Wittmaxi Wittmaxi mentioned this issue Jul 8, 2024
Open
72 tasks
Wittmaxi pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 8, 2024
Find/Replace Overlay: correctly set scope mode
666db2f 
Depending on the file format, the line separators are different.
This PR allows detecting both when deciding whether to set the scoped
search mode or not when opening the Overlay with an active selection.

fixes eclipse-platform#2054
@Wittmaxi Wittmaxi mentioned this issue Jul 8, 2024
Merged
Wittmaxi pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 8, 2024
Find/Replace Overlay: correctly set scope mode
88f1f62 
Depending on the file format, the line separators are different.
This PR allows detecting both when deciding whether to set the scoped
search mode or not when opening the Overlay with an active selection.

fixes eclipse-platform#2054
HeikoKlare pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 8, 2024
@HeikoKlare
Find/Replace Overlay: correctly set scope mode
ec40478 
Depending on the file format, the line separators are different.
This PR allows detecting both when deciding whether to set the scoped
search mode or not when opening the Overlay with an active selection.

fixes eclipse-platform#2054
HeikoKlare pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Find/Replace Overlay: correctly set scope mode
9b7145a 
Depending on the file format, the line separators are different.
This PR allows detecting both when deciding whether to set the scoped
search mode or not when opening the Overlay with an active selection.

fixes eclipse-platform#2054
HeikoKlare pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Find/Replace Overlay: correctly set scope mode
3153f2c 
Depending on the file format, the line separators are different.
This PR allows detecting both when deciding whether to set the scoped
search mode or not when opening the Overlay with an active selection.

fixes eclipse-platform#2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Find/Replace Overlay: correctly set scope mode Wittmaxi/eclipse.platform.ui
1 participant
@Wittmaxi