Improve find/replace overlay icons for expand/collapse on Mac #1983 #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.images
that referenced
this pull request
Jul 4, 2024
Adapts the color of collapse/expand icons for the find/replace overlay to properly work with dark theme on MacOS. See eclipse-platform/eclipse.platform.ui#2028
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.images
that referenced
this pull request
Jul 4, 2024
Adapts the color of collapse/expand icons for the find/replace overlay to properly work with dark theme on MacOS. See eclipse-platform/eclipse.platform.ui#2028
|
Thanks for your immediate feedback! I have added screenshots for comparing the effect on Windows and MacOS as well and added them to the PR description. I have created the according PR for the images repo (eclipse-platform/eclipse.platform.images#79), also containing the modified SVGs. |
Test Results 1 210 files ±0 1 210 suites ±0 1h 3m 44s ⏱️ + 2m 13s For more details on these failures, see this check. Results for commit 1f69ff8. ± Comparison against base commit 354e1b7. ♻️ This comment has been updated with latest results. |
…-platform#1983 The icons for expand/collapse in the find/replace overlay are hardly visible on Mac when using dark theme, because the contrast between icon color and background color is too low. This adapts the icon color to be properly visible on all operating systems and themes. Fixes eclipse-platform#1983
HeikoKlare
added a commit
to eclipse-platform/eclipse.platform.images
that referenced
this pull request
Jul 4, 2024
Adapts the color of collapse/expand icons for the find/replace overlay to properly work with dark theme on MacOS. See eclipse-platform/eclipse.platform.ui#2028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icons for expand/collapse in the find/replace overlay are hardly visible on Mac when using dark theme, because the contrast between icon color and background color is too low. This adapts the icon color to be properly visible on all operating systems and themes.
I would even prefer to have the icon change its color depending on the theme, but using icon fonts, which would solve that problem, produced problems on Linux: #1960
Fixes #1983
Appearance on MacOS
Note that the different sizes of the expand/collapse button are independent from the changes here and part of another issue (#2018).
Existing:
New:
Appearance on Windows
Existing
New
Appearance on Linux
Existing
New