Improve styling of expand/collapse button in find/replace overlay #2018 #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasritter could you please test whether this PR fixes the issue(s) you have reported in #2018? |
HeikoKlare
force-pushed
the
issue-2018
branch
3 times, most recently
from
40702b0 to
0b3229b
Compare
…ipse-platform#2018 The button for expanding the find/replace overlay to show the replace bar it quite large on MacOS and also changes its size upon different events, such activating options and scrolling in the editor target. With this change, the button style is changed to "FLAT". It results in a less space-consuming layout and fixes its size so that it does not resize on events like scrolling in the target editor. Fixes eclipse-platform#2018
|
I've tested again the (MacOS) scenarios described in #2018 and found all of them fixed. I've verified again that the change does not affect Windows and Linux. So let's merge this and see if it actually fixes the mentioned issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button for expanding the find/replace overlay to show the replace bar it quite large on MacOS and also changes its size upon different events, such activating options and scrolling in the editor target.
With this change, the button style is changed to "FLAT". It results in a less space-consuming layout and fixes its size so that it does not resize on events like scrolling in the target editor.
Fixes #2018
Appearance on MacOS
Existing
New
Appearance on Windows and Linux
The change has no effect on Windows and Linux.