Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

564566 [Passage] API revision | rework passage settings dirs supplying #267

Merged
merged 6 commits into from
Jun 26, 2020

Conversation

eparovyshnaya
Copy link
Contributor

 - rework `LicensingPaths` to corresponding suppliers
 - deprecate each of utils with proper references

Signed-off-by: elena.parovyshnaya <[email protected]>
 - export new `internal.io` package

Signed-off-by: elena.parovyshnaya <[email protected]>
 - rework `EquinoxPaths` utilities to new `lic.internal.equinox.io`
classes
 - completely deprecate both `LicensingPaths` and `EquinoxPath` with
references to the replacements

Signed-off-by: elena.parovyshnaya <[email protected]>
 - add `user.home` - resident passage data folder supplier

Signed-off-by: elena.parovyshnaya <[email protected]>
 - add `user.home` - resident passage data folder supplier

Signed-off-by: elena.parovyshnaya <[email protected]>
 - rework back to direct not-null argument as retrieval logic (throwing
exceptions on any invalid case) is supplied by LicensedApplication class

Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed June 26, 2020 08:38
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #267 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   11.70%   11.67%   -0.03%     
==========================================
  Files         611      619       +8     
  Lines       15371    15409      +38     
  Branches     1175     1174       -1     
==========================================
  Hits         1799     1799              
- Misses      13527    13565      +38     
  Partials       45       45              
Impacted Files Coverage Δ
...rg/eclipse/passage/lic/base/io/LicensingPaths.java 0.00% <ø> (ø)
.../internal/base/io/FileNameFromLicensedProduct.java 0.00% <0.00%> (ø)
.../passage/lic/internal/base/io/LicensingFolder.java 0.00% <0.00%> (ø)
...age/lic/internal/base/io/PassageFileExtension.java 0.00% <0.00%> (ø)
.../lic/internal/base/io/PathFromLicensedProduct.java 0.00% <0.00%> (ø)
...passage/lic/internal/base/io/PathFromLocalUrl.java 0.00% <0.00%> (ø)
...pse/passage/lic/internal/base/io/UserHomePath.java 0.00% <0.00%> (ø)
...g/eclipse/passage/lic/equinox/io/EquinoxPaths.java 0.00% <0.00%> (ø)
...ternal/equinox/LicensedApplicationFromContext.java 0.00% <0.00%> (ø)
...nal/equinox/conditions/UserHomeConditionMiner.java 0.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe0f20...5589928. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 9893417 into master Jun 26, 2020
@eparovyshnaya eparovyshnaya deleted the 564566 branch June 26, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants