564566 [Passage] API revision | rework passage settings dirs supplying #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invite new interface to represent `LicensingConfiguration` - deprecate the previous one - move revised retrieval services to the new interface Signed-off-by: elena.parovyshnaya <[email protected]>
- let framework be responsible for LicensedProduct coordinates supplying - invite general purpose LicensingException to separate severe environment misbehaviour detection (like facing the fact that there is no application context service) from business-logic decisions taken basing on this facts Signed-off-by: elena.parovyshnaya <[email protected]>
- `LicensingConfiguration`, even deprecated, must be implemented as a data-class according to expectations Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 11.70% 11.70% -0.01%
==========================================
Files 609 611 +2
Lines 15324 15371 +47
Branches 1172 1175 +3
==========================================
+ Hits 1794 1799 +5
- Misses 13482 13527 +45
+ Partials 48 45 -3
Continue to review full report at Codecov.
|
ruspl-afed
reviewed
Jun 26, 2020
...lic.equinox/src/org/eclipse/passage/lic/internal/equinox/LicensedApplicationFromContext.java
Show resolved
Hide resolved
...lic.equinox/src/org/eclipse/passage/lic/internal/equinox/LicensedApplicationFromContext.java
Show resolved
Hide resolved
ruspl-afed
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
LicensingConfigurationis a key source of data for paths supplying,is it reworked as following:
LicensingConfigurationis invited (the previous one is deprecated)Frameworkis entitled for being responsible forLicensedProductcoordinates providing