Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1375] Revise public API #1378

Merged
merged 4 commits into from
May 25, 2024
Merged

[#1375] Revise public API #1378

merged 4 commits into from
May 25, 2024

Conversation

eparovyshnaya
Copy link
Contributor

part of API, that was promoted to public access by mistake, made provisional

part of API, that was promoted to public access by mistake, made
provisional
part of API, that was promoted to public access by mistake, made
provisional
part of API, that was promoted to public access by mistake, made
provisional
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

access cycle implementation is not part of api, goes to internal package
@eparovyshnaya eparovyshnaya merged commit 73aaa5c into master May 25, 2024
4 checks passed
@eparovyshnaya eparovyshnaya added this to the 3.0.0 milestone May 25, 2024
@eparovyshnaya eparovyshnaya mentioned this pull request May 25, 2024
@ruspl-afed ruspl-afed deleted the 1375-public-api branch May 25, 2024 14:59
@HannesWell
Copy link
Contributor

@eparovyshnaya I think you want to check your loca git core.autocrlf configuration. You are currently chaning many files to be checked in with Windows-style(CRLF) line-endings while it is usually recommended to use Unix-style (LF). On the long run Windows-style line-endings in git usually leads to obscure behavior of git on Windows.

To convert all the files back you can run the following command (pay attention to the trailing dot):
git add --renormalize .

@eparovyshnaya
Copy link
Contributor Author

@HannesWell thank you very much for the care. Will do as you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants