Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise public API #1375

Closed
eparovyshnaya opened this issue May 23, 2024 · 2 comments
Closed

Revise public API #1375

eparovyshnaya opened this issue May 23, 2024 · 2 comments
Assignees
@eparovyshnaya @ruspl-afed
Labels
component::api Eclipse Passage API
Milestone
3.0.0

Comments

@eparovyshnaya
Copy link
Contributor

It appeared that lots of codebase, that does not directly facilitate Passage Runtime, are declared as public API.
For instance,

  • lic.emf
  • lic.jface (actions included)
  • lic.hc
  • lic.bc
  • lic.e4.ui
  • hand-written parts of model and edit plug-ins
  • lic.oshi
  • loc*
  • lbc*

and others.

In the light this discovery it is demanded to revise the whole sourcebase and move parts of code unrelevant to Passage Runtime contract to provisional API.
@eparovyshnaya eparovyshnaya added this to the 3.0.0 milestone May 23, 2024
@eparovyshnaya eparovyshnaya added the component::api Eclipse Passage API label May 23, 2024
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
747f9dc 
part of API, that was promoted to public access by mistake, made
provisional

Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
bede136 
impl-packages of generated model code declared provisional

Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
0caaa98 
part of API, that was promoted to public access by mistake, made
provisional
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
c58b336 
part of API, that was promoted to public access by mistake, made
provisional
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
f562e1b 
part of API, that was promoted to public access by mistake, made
provisional
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
44590a5 
part of API, that was promoted to public access by mistake, made
provisional
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
7986897 
access cycle implementation is not part of api, goes to internal package
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
604141a 
part of API, that was promoted to public access by mistake, made
provisional
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
149c18e 
part of API, that was promoted to public access by mistake, made
provisional
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
a5454d9 
part of API, that was promoted to public access by mistake, made
provisional
eparovyshnaya added a commit that referenced this issue May 25, 2024
@eparovyshnaya
[#1375] Revise public API
73aaa5c 
access cycle implementation is not part of api, goes to internal package
@eparovyshnaya
Copy link
Contributor Author

Done with #1378

@eparovyshnaya eparovyshnaya reopened this May 25, 2024
@eparovyshnaya
Copy link
Contributor Author

All passage domain's ResourceFactories should be moved to internal packages, as they contain customiztions that cannot be part of protocol.

eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
0cc39ff 
move AgreementsResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
aed71ed 
move FeaturesResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
701d6c5 
move KeysResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
8aff48e 
move LicensesResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
cbe0a5b 
move ProductsResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
2f489bf 
move UsersResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
20307a3 
fix line endings
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
689bbf5 
move AgreementsResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
66e0bc9 
move FeaturesResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
3272d9b 
move KeysResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
3c12948 
move LicensesResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
4227443 
move ProductsResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
58d9be1 
move UsersResource and Factory to internal package
eparovyshnaya added a commit that referenced this issue May 28, 2024
@eparovyshnaya
[#1375] Revise public API
d40cc85 
fix line endings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eparovyshnaya eparovyshnaya

@ruspl-afed ruspl-afed

Labels
component::api Eclipse Passage API
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@eparovyshnaya @ruspl-afed