Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1300] license issuing dialogs: keep selection #1301

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[#1300] license issuing dialogs: keep selection #1301

merged 1 commit into from
Feb 26, 2024

Conversation

eparovyshnaya
Copy link
Contributor

No description provided.

@eparovyshnaya eparovyshnaya added this to the 2.11.0 milestone Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 7.04225% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 33.67%. Comparing base (c518268) to head (5d977c9).

Files Patch % Lines
...pse/passage/loc/internal/users/ui/SelectUsers.java 0.00% 10 Missing ⚠️
.../dashboard/ui/wizards/license/SelectableField.java 0.00% 8 Missing ⚠️
...ge/loc/internal/workbench/SupplySelectRequest.java 0.00% 6 Missing ⚠️
...loc/dashboard/ui/wizards/license/LabeledField.java 0.00% 5 Missing ⚠️
...se/passage/loc/internal/workbench/SelectInner.java 0.00% 5 Missing ⚠️
...se/passage/loc/internal/workbench/SelectRoots.java 0.00% 5 Missing ⚠️
...ge/loc/internal/licenses/ui/SelectLicensePlan.java 0.00% 4 Missing ⚠️
...loc/internal/products/ui/SelectProductVersion.java 0.00% 4 Missing ⚠️
...ipse/passage/loc/internal/users/ui/SelectUser.java 0.00% 4 Missing ⚠️
...pse/passage/loc/internal/workbench/SelectRoot.java 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1301      +/-   ##
============================================
- Coverage     33.73%   33.67%   -0.07%     
  Complexity      391      391              
============================================
  Files          1185     1186       +1     
  Lines         25903    25945      +42     
  Branches       1592     1593       +1     
============================================
- Hits           8738     8736       -2     
- Misses        16645    16689      +44     
  Partials        520      520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruspl-afed ruspl-afed merged commit cf9c499 into master Feb 26, 2024
4 of 6 checks passed
@ruspl-afed ruspl-afed deleted the 1300 branch February 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants