Remove passage.lbc.target.feature from passage.lbc.execute.feature

[HannesWell]

Fixes #1123

[codecov]

Codecov Report

Merging #1126 (f0b8787) into master (5e58dac) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1126   +/-   ##
=========================================
  Coverage     33.20%   33.20%           
  Complexity      356      356           
=========================================
  Files          1161     1161           
  Lines         25699    25699           
  Branches       1588     1588           
=========================================
  Hits           8534     8534           
- Misses        16659    16660    +1     
+ Partials        506      505    -1     

Impacted Files	Coverage Δ
...rg/eclipse/passage/lic/bc/BcResidentSecretKey.java	91.30% <0.00%> (-4.35%)	⬇️
...bc/internal/base/acquire/DefaultGrantsStorage.java	77.96% <0.00%> (+1.69%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ruspl-afed]

Yes, we can remove this feature from the list of "requires".
However, this fix does not look complete, perhaps org.eclipse.passage.lbc.target.feature feature is not needed at all.

[HannesWell]

Yes, we can remove this feature from the list of "requires". However, this fix does not look complete, perhaps org.eclipse.passage.lbc.target.feature feature is not needed at all.

It is not unlikely that this feature is not required at all, especially if the included Plug-ins are already required by any one of Passage's plugins.
If you want I can create a PR to remove this target-feature.

[HannesWell]

Yes, we can remove this feature from the list of "requires". However, this fix does not look complete, perhaps org.eclipse.passage.lbc.target.feature feature is not needed at all.

It looks like that feature is used in the org.eclipse.passage.lbc.repository to include passage dependencies. Therefore I think you should keep it to build that repo.

[ruspl-afed]

I know, and it is used also for FLS product definition. The question was a bit wider, but we can forget about it for a while.

[HannesWell]

I know, and it is used also for FLS product definition. The question was a bit wider, but we can forget about it for a while.

You build the products with Tycho, don't you? Because Tycho/P2 installs all required dependencies automatically into the product, so that is actually not necessary. But the passage.lbc.target.feature is marked as root feature, so your intention is to allow updating of that plugin independently? Or is that just by chance?

[ruspl-afed]

You build the products with Tycho, don't you?

we do.

so your intention is to allow updating of that plugin independently? Or is that just by chance?

I think this feature was containing much more in the past and the intention was to allow upgrading this "target" independently.