Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove o.e.passage.lbc.target.feature from o.e.passage.lbc.execute.feature #1123

Closed
HannesWell opened this issue Sep 20, 2022 · 0 comments · Fixed by #1126
Closed

Remove o.e.passage.lbc.target.feature from o.e.passage.lbc.execute.feature #1123

HannesWell opened this issue Sep 20, 2022 · 0 comments · Fixed by #1126
Assignees

Comments

@HannesWell
Copy link
Contributor

The Feature org.eclipse.passage.lbc.target.feature contains some dependencies of passage bundles with a fixed versions (due to how Tycho/P2 builds them) that are from a previous Eclipse releases.
The Feature org.eclipse.passage.lbc.execute.feature requires o.e.passage.lbc.target.feature and therefore forces the content of the latter to be present in the TP or application. Because the target-feature contains Plug-ins that are singletons the passage.lbc.execute.feature for Passage 2.5 cannot be used with with the recent Eclipse 2022-09 features in one Target-Platform.

Because PDE and P2/Tycho (can) add required dependencies of Plugins to a launched or build Eclipse product automatically there is actually no need to have a target feature.
Therefore I suggest to remove the dependency to o.e.passage.lbc.target.feature from o.e.passage.lbc.execute.feature.
I can provide a PR to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants