Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize AArch64 and RISC-V in DDR TraceFileHeaderWriter #18648

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Dec 19, 2023

Fixes: #18647

@knn-k
Copy link
Contributor Author

knn-k commented Dec 19, 2023

This commit depends on eclipse-omr/omr#7208 and #18643.

@knn-k
Copy link
Contributor Author

knn-k commented Dec 19, 2023

Jenkins compile alinux64 jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Dec 20, 2023

How can I test this? Are the steps below correct?

  1. Generate a core file
  2. Run !snaptrace command in jdmpview to generate a .trc file
  3. Run traceformat to generate a .fmt file from the .trc file

@pshipton
Copy link
Member

Perhaps @keithc-ca will comment in the new year.

@keithc-ca
Copy link
Contributor

Are the steps below correct?

Yes, that is the way you would test this.

@knn-k knn-k marked this pull request as ready for review January 10, 2024 22:40
@knn-k
Copy link
Contributor Author

knn-k commented Jan 10, 2024

Jenkins compile alinux64 jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Jan 10, 2024

Jenkins compile alinux64 jdk17

The previous build failed with the following error:

[2024-01-10T23:27:33.999Z] curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 104

@knn-k
Copy link
Contributor Author

knn-k commented Jan 11, 2024

Build failed again with the same curl error:

[2024-01-10T23:38:01.457Z] + curl -LJkO 'https://api.adoptopenjdk.net/v3/binary/latest/17/ga/linux/aarch64/jdk/openj9/normal/adoptopenjdk?project=jdk'
...
 60  197M   60  120M    0     0   140k      0  0:23:54  0:14:34  0:09:20     0
[2024-01-10T23:52:36.874Z] curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 104

@knn-k
Copy link
Contributor Author

knn-k commented Jan 11, 2024

I can see the following information in the .fmt file generated from a .trc file on AArch64 Linux, using my local build. Arch family is set correctly. Processor Sub-type is wrong, but it seems other architectures do not set it correctly, as I showed an example on x86-64 Linux in #18647 (comment).

Processor information:
        Arch family:         AArch64
        Processor Sub-type:  i486
        Num Processors:      8
        Big Endian:          false
        Word size:           64
        Using Trace Counter: J9 timer

@knn-k
Copy link
Contributor Author

knn-k commented Jan 11, 2024

Jenkins compile alinux64 jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Jan 11, 2024

I haven't tested this on RISC-V.

@keithc-ca keithc-ca merged commit fc0265c into eclipse-openj9:master Jan 11, 2024
4 checks passed
@knn-k knn-k deleted the ddrTraceFileHeaderWriter branch January 12, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AArch64 and RISC-V are missing in DDR TraceFileHeaderWriter.java
3 participants