Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize AArch64 in traceformat #18643

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Recognize AArch64 in traceformat #18643

merged 1 commit into from
Jan 10, 2024

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Dec 18, 2023

This commit adds AArch64 to the architectures recognized by traceformat.

Fixes: #18536

@knn-k
Copy link
Contributor Author

knn-k commented Dec 18, 2023

This commit depends on eclipse-omr/omr#7208

@knn-k
Copy link
Contributor Author

knn-k commented Dec 18, 2023

I see the traceformat output as shown below with this fix:

Processor information:
        Arch family:         AArch64
        Processor Sub-type:  Armv8
        Num Processors:      4
        Big Endian:          false
        Word size:           64
        Using Trace Counter: J9 timer

@knn-k
Copy link
Contributor Author

knn-k commented Dec 18, 2023

Jenkins test sanity alinux64,amac jdk17 depends eclipse-omr/omr#7208

@knn-k knn-k marked this pull request as ready for review December 18, 2023 21:49
@knn-k knn-k marked this pull request as draft December 18, 2023 22:24
This was referenced Dec 18, 2023
Closed
Merged
@knn-k knn-k marked this pull request as ready for review December 20, 2023 01:44
@knn-k
Copy link
Contributor Author

knn-k commented Dec 20, 2023

@0xdaryl FYI.

@knn-k
Copy link
Contributor Author

knn-k commented Dec 21, 2023

@keithc-ca Would you review this PR, please? Not in a hurry.

@keithc-ca keithc-ca self-requested a review January 2, 2024 18:06
@keithc-ca keithc-ca self-assigned this Jan 2, 2024
@knn-k
Copy link
Contributor Author

knn-k commented Jan 9, 2024

Jenkins compile all jdk17

@knn-k
Recognize AArch64 in traceformat
aa1300b 
This commit adds AArch64 to the architectures recognized by traceformat.

Fixes: eclipse-openj9#18536

Signed-off-by: KONNO Kazuhiro <[email protected]>
keithc-ca
keithc-ca requested changes Jan 9, 2024
View reviewed changes
runtime/rastrace/trclog.c Outdated Show resolved Hide resolved
@knn-k
Copy link
Contributor Author

knn-k commented Jan 9, 2024

Jenkins compile all jdk17

@keithc-ca keithc-ca merged commit 824a28d into eclipse-openj9:master Jan 10, 2024
8 checks passed
@knn-k knn-k deleted the aarch64trcformat branch January 10, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees

@keithc-ca keithc-ca

Labels
arch:aarch64 comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AArch64: Wrong processor type with traceformat
3 participants
@knn-k @keithc-ca @pshipton