DOM document should store Invalid end tag </
#887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
EndTagFake
branch
from
5707527 to
fdeb53f
Compare
|
This PR will be very helpful to fix some error range highlight and some code actions. For the moment the invalid end tag support is used for symbol (outline) and formatting. Here a demo with outline and formatting:
|
datho7561
requested changes
Sep 24, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/DOMElement.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLCompletions.java
Show resolved
Hide resolved
angelozerr
force-pushed
the
EndTagFake
branch
from
fdeb53f to
7e6f383
Compare
Fixes eclipse-lemminx#886 Signed-off-by: azerr <[email protected]>
datho7561
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOM document should store Invalid end tag
</Fixes #886
Signed-off-by: azerr [email protected]