Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM document should store Invalid end tag </ #886

Closed
angelozerr opened this issue Sep 24, 2020 · 0 comments · Fixed by #887
Closed

DOM document should store Invalid end tag </ #886

angelozerr opened this issue Sep 24, 2020 · 0 comments · Fixed by #887
Milestone

Comments

@angelozerr
Copy link
Contributor

While working on #881 I notice that it was very hard to support usecase with invalid end tag </ (it's hard for instance to detect it to eat it for instance with code action).

The main problem is that DOM document doesn't stores this invalid end tag.

We can see this problem for instance if you have this XML:

<a>
  </
</a>

The outline doesn't show the </ (although it shows start tag like < and if you format this XML you loose the </ content.

angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 24, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 24, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 24, 2020
angelozerr added a commit that referenced this issue Sep 25, 2020
@angelozerr angelozerr added this to the 0.14.0 milestone Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant