-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to set catalog prefer as public in vscode setting? #844
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
...rc/main/java/org/eclipse/lemminx/extensions/contentmodel/settings/XMLCatalogSettings.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/******************************************************************************* | ||
* Copyright (c) 2020 Red Hat Inc. and others. | ||
* All rights reserved. This program and the accompanying materials | ||
* which accompanies this distribution, and is available at | ||
* http://www.eclipse.org/legal/epl-v20.html | ||
* | ||
* SPDX-License-Identifier: EPL-2.0 | ||
* | ||
* Contributors: | ||
* Red Hat Inc. - initial API and implementation | ||
*******************************************************************************/ | ||
package org.eclipse.lemminx.extensions.contentmodel.settings; | ||
|
||
/** | ||
* XML catalog settings. | ||
* | ||
*/ | ||
public class XMLCatalogSettings { | ||
|
||
public static String DEFAULT_PREFER_PUBLIC = "public"; | ||
|
||
public static boolean DEFAULT_USE_PREFER_PUBLIC = true; | ||
|
||
public static boolean DEFAULT_USE_LITERAL_SYSTEM_ID = true; | ||
|
||
public static final XMLCatalogSettings DEFAULT_CATALOG = new XMLCatalogSettings(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. default catalog should be immutable |
||
|
||
private String prefer; | ||
|
||
private String[] files = null; | ||
|
||
private boolean useLiteralSystemId; | ||
|
||
public XMLCatalogSettings() { | ||
setPrefer(DEFAULT_PREFER_PUBLIC); | ||
setUseLiteralSystemId(DEFAULT_USE_LITERAL_SYSTEM_ID); | ||
} | ||
|
||
public String getPrefer() { | ||
return prefer; | ||
} | ||
|
||
public void setPrefer(String prefer) { | ||
this.prefer = prefer; | ||
} | ||
|
||
public boolean isPreferPublic() { | ||
return DEFAULT_PREFER_PUBLIC.equals(getPrefer()); | ||
} | ||
|
||
public String[] getFiles() { | ||
return files; | ||
} | ||
|
||
public void setFiles(String[] files) { | ||
this.files = files; | ||
} | ||
|
||
public boolean isUseLiteralSystemId() { | ||
return useLiteralSystemId; | ||
} | ||
|
||
public void setUseLiteralSystemId(boolean useLiteralSystemId) { | ||
this.useLiteralSystemId = useLiteralSystemId; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it used to never return null, you should keep that