How to set catalog prefer as public in vscode setting? #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
Aug 18, 2020
| return catalog.getFiles(); | ||
| } | ||
| } | ||
| return catalogs; |
There was a problem hiding this comment.
it used to never return null, you should keep that
|
|
||
| public static boolean DEFAULT_USE_LITERAL_SYSTEM_ID = true; | ||
|
|
||
| public static final XMLCatalogSettings DEFAULT_CATALOG = new XMLCatalogSettings(); |
There was a problem hiding this comment.
default catalog should be immutable
|
please use a proper commit message (explaining the change) |
angelozerr
force-pushed
the
catalog-preferences
branch
from
f60340f to
47a98a3
Compare
See redhat-developer/vscode-xml#295 Signed-off-by: azerr <[email protected]>
|
I close this issue since original issue redhat-developer/vscode-xml#295 doesn't require this new settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to set catalog prefer as public in vscode setting?
See redhat-developer/vscode-xml#295
Signed-off-by: azerr [email protected]