Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a dedicated DTD Validator #223

Closed
fbricon opened this issue Nov 14, 2018 · 2 comments
Closed

Provide a dedicated DTD Validator #223

fbricon opened this issue Nov 14, 2018 · 2 comments
Assignees
Labels
bug Something isn't working DTD to do validation
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 14, 2018

if you save http://java.sun.com/dtd/web-app_2_3.dtd locally and open it in VS Code, an error shows up on the 1st ELEMENT, L72. "The markup in the document preceding the root element must be well-formed."
DTDs do not follow the actual xml syntax but are part of the XML spec, so "The markup in the document preceding the root element must be well-formed." (and maybe other specific errors) should be ignored.
We still need tooling support for DTD (completion, validation ...)

@fbricon fbricon added bug Something isn't working DTD labels Nov 14, 2018
@angelozerr angelozerr changed the title "The markup in the document ... must be well-formed." error when opening a DTD Provide a dedicated DTD Validator Nov 15, 2018
@angelozerr angelozerr self-assigned this Nov 15, 2018
@angelozerr angelozerr added this to the v0.0.3 milestone Nov 15, 2018
@angelozerr
Copy link
Contributor

@fbricon it shoud work better. Now you should have just DTD syntax error. It misses now adjust error range but to do that I'm waiting for the work of @NikolasKomonen about the improve of parser.

@fbricon fbricon added the to do label Nov 15, 2018
@angelozerr
Copy link
Contributor

angelozerr commented Nov 15, 2018

I close this issue since DTD validator is implemented. It misses tests and adjust error which will be done in #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DTD to do validation
Projects
None yet
Development

No branches or pull requests

2 participants