Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTD validation should be specific #88

Closed
fbricon opened this issue Nov 14, 2018 · 4 comments
Closed

DTD validation should be specific #88

fbricon opened this issue Nov 14, 2018 · 4 comments
Labels
bug Something isn't working DTD
Milestone

Comments

@fbricon
Copy link
Collaborator

fbricon commented Nov 14, 2018

if you save http://java.sun.com/dtd/web-app_2_3.dtd locally and open it in VS Code, an error shows up on the 1st ELEMENT, L72. "The markup in the document preceding the root element must be well-formed."
DTDs are not actual xml documents themselves, so they should not be validated against lsp4xml.

@fbricon fbricon added the bug Something isn't working label Nov 14, 2018
@fbricon fbricon added this to the 0.3.0 milestone Nov 14, 2018
@angelozerr
Copy link
Contributor

angelozerr commented Nov 14, 2018

It's an issue for lsp4xml, no? More perhaps we should have support for DTD himself like completion and validation. I don't know if xerces provides those features.

@fbricon
Copy link
Collaborator Author

fbricon commented Nov 14, 2018

Because DTD is actually part of the XML spec, we should probably be able to get tooling support for it, but "The markup in the document preceding the root element must be well-formed." should be ignored. So it might be a server-side issue after all

@fbricon
Copy link
Collaborator Author

fbricon commented Nov 14, 2018

I opened eclipse-lemminx/lemminx#223 upstream

@fbricon fbricon added DTD to do and removed DTD labels Nov 15, 2018
@fbricon
Copy link
Collaborator Author

fbricon commented Nov 15, 2018

The error no longer shows up

@fbricon fbricon closed this as completed Nov 15, 2018
@fbricon fbricon removed the to do label Dec 5, 2018
@fbricon fbricon changed the title DTDs should not be validated against lsp4xml DTD validation should be specific Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DTD
Projects
None yet
Development

No branches or pull requests

2 participants