Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Unused properties inside Mojos #259

Closed
rohanKanojia opened this issue Jun 25, 2020 · 1 comment · Fixed by #282
Closed

Cleanup Unused properties inside Mojos #259

rohanKanojia opened this issue Jun 25, 2020 · 1 comment · Fixed by #282
Assignees
@rohanKanojia
Milestone
1.0.0

Comments

@rohanKanojia
Copy link
Member

These are some mojo @Parameter properties inside our mojo which are not directly used in mojo and are used across various places inside JKube Kit.

We had a discussion in #244 (comment) about this and we decided to revisit this and check all Mojos and remove all the properties which are not directly used in Mojos directly. An example of these kind of properties are these, which are now moved to OpenShiftResourceMojo:

https://github.com/eclipse/jkube/blob/48ccd83fc8ffd81e3d8716b4fa8b43177ae6755d/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ResourceMojo.java#L249-L260
@rohanKanojia rohanKanojia mentioned this issue Jun 25, 2020
Merged
11 tasks
@manusa manusa added this to the 1.0.0 milestone Jun 25, 2020
@manusa
Copy link
Member

manusa commented Jun 25, 2020

Relates to #248

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 8, 2020
@rohanKanojia
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
449f683
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 8, 2020
@rohanKanojia
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
a194a43
@rohanKanojia rohanKanojia mentioned this issue Jul 8, 2020
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 8, 2020
@rohanKanojia
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
1b8aaa7
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 8, 2020
@rohanKanojia
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
2aa63c3
rohanKanojia added a commit that referenced this issue Jul 8, 2020
@rohanKanojia
Fix #259: Cleanup Unused properties inside Mojos
76b9eb3
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
0a0b115 
Signed-off-by: Tue Dissing <[email protected]>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia @TueDissingWork
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
3290075
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia @TueDissingWork
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
b6507bb
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia @TueDissingWork
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
e61fbdb
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia @TueDissingWork
Fix eclipse-jkube#259: Cleanup Unused properties inside Mojos
e3faf93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Fix #259: Cleanup Unused properties inside Mojos rohanKanojia/jkube
2 participants
@manusa @rohanKanojia