Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release to marketplace #27

Closed
maxandersen opened this issue Jul 6, 2016 · 3 comments
Closed

release to marketplace #27

maxandersen opened this issue Jul 6, 2016 · 3 comments
Assignees
@gorkem
Milestone
August 2016

Comments

@maxandersen
Copy link

No description provided.

@egamma egamma modified the milestone: Hackathon Jul 6, 2016
@egamma
Copy link

egamma commented Jul 14, 2016 •
edited
Loading

One thing to keep in mind is that the market place has a maximum size of 20MB for an extension. Since this extension will include a subset of eclipse, the extension will exceed this limit.

One way to achieve this is that the extension downloads the eclipse bits on first activation of the extension. This is also how it is done by the vscode-omnisharp extension.

Please see: https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/omnisharp/serverLauncher.ts

@gorkem fyi

@gorkem
Copy link
Contributor

gorkem commented Jul 14, 2016

@egamma Thanks for the heads up. I did not notice the limitation.

@maxandersen maxandersen assigned gorkem and unassigned maxandersen Jul 29, 2016
@gorkem gorkem added this to the August 2016 milestone Aug 2, 2016
@gorkem gorkem mentioned this issue Aug 15, 2016
Closed
@gorkem
Copy link
Contributor

gorkem commented Aug 15, 2016

This issue was moved to gorkem/vscode-java#1

@gorkem gorkem closed this as completed Aug 15, 2016
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Oct 31, 2016
@fbricon
Fix eclipse-jdtls#27 support standalone java files
f108b68 
- Standalone Java files are linked to a default Java project providing a default classpath allowing for content assist for Base JDK classes
- the Java files must exist and be referenced with a file:// uri

Signed-off-by: Fred Bricon <[email protected]>
fbricon pushed a commit to fbricon/eclipse.jdt.ls that referenced this issue Aug 21, 2017
@ansyral
Merge pull request eclipse-jdtls#27 from ansyral/buildfailure
8604fa2 
fix build failure after ls updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gorkem gorkem

Labels
None yet
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
3 participants
@maxandersen @gorkem @egamma