Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release to marketplace #1

Closed
gorkem opened this issue Aug 15, 2016 · 4 comments
Closed

release to marketplace #1

gorkem opened this issue Aug 15, 2016 · 4 comments
Assignees
Milestone

Comments

@gorkem
Copy link
Contributor

gorkem commented Aug 15, 2016

From @maxandersen on July 6, 2016 14:59

Copied from original issue: eclipse-jdtls/eclipse.jdt.ls#27

@gorkem
Copy link
Contributor Author

gorkem commented Aug 15, 2016

From @egamma on July 14, 2016 8:30

One thing to keep in mind is that the market place has a maximum size of 20MB for an extension. Since this extension will include a subset of eclipse, the extension will exceed this limit.

One way to achieve this is that the extension downloads the eclipse bits on first activation of the extension. This is also how it is done by the vscode-omnisharp extension.

Please see: https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/omnisharp/serverLauncher.ts

@gorkem fyi

@gorkem gorkem self-assigned this Aug 15, 2016
@gorkem
Copy link
Contributor Author

gorkem commented Aug 15, 2016

@egamma Thanks for the heads up. I did not notice the limitation.

@yzhang-gh
Copy link

Looking forward to it 😄

@gorkem gorkem added this to the 0.0.1 milestone Sep 5, 2016
@gorkem
Copy link
Contributor Author

gorkem commented Sep 12, 2016

Released at https://marketplace.visualstudio.com/items?itemName=redhat.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants