Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundles depending on Java 17 bundles to Java 17 #218

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

iloveeclipse
Copy link
Member

  • used default PDE quickfixes
  • updated pom versions manually
  • bumped test bundle versions manually
  • bumped feature versions manually
  • changed buildExtraJAR.xml to use 1.7 as compilation target (jsr14 is not supported anymore)
  • changed buildExtraJAR.xml to use zip instead of jar to create snippetsupport.jar (avoids creating useless and ever changing manifest)

This commit requires a fix for
#217 (because of the hard coded line 28 in filterDebugEvents() method in JavaSnippetEditor.java).

Fixes #210

@iloveeclipse
Copy link
Member Author

TODO:

  1. Tests update to Java 17
  2. Fix for org.eclipse.jdt.debug.ui/snippetsupport.jar, if rebuilt, breaks snippet editor #217 (I know how to fix, just need to be properly prepared)

@iloveeclipse
Copy link
Member Author

Note: all tests are green, even if snippet editor evaluation is broken:
https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-github/job/PR-218/1/console

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Mar 28, 2023

Now after rebase on #220 one test will fail.

@iloveeclipse
Copy link
Member Author

As expected:

junit.framework.ComparisonFailure: Editor should show evaluation result expected:<2 + 2[(int) 4]> but was:<2 + 2[]>
	at junit.framework.Assert.assertEquals(Assert.java:100)
	at junit.framework.TestCase.assertEquals(TestCase.java:253)
	at org.eclipse.jdt.debug.tests.ui.JavaSnippetEditorTest.testEvaluation(JavaSnippetEditorTest.java:100)

Fix follows soon.

- used default PDE quickfixes
- updated pom versions manually
- bumped test bundle versions manually
- bumped feature versions manually
- changed buildExtraJAR.xml to use 1.7 as compilation target (jsr14 is
not supported anymore)
- changed buildExtraJAR.xml to use zip instead of jar to create
snippetsupport.jar (avoids creating useless and ever changing manifest)

Fixes eclipse-jdt#210
- updated line reference to actual one
- fixed deprecated warnings after Java 17 update
- fixed resource leak warnings after Java 17 update
- re-generated snippetsupport.jar

See
- eclipse-jdt#210
- eclipse-jdt#217
@iloveeclipse iloveeclipse merged commit 7a8141c into eclipse-jdt:master Mar 28, 2023
@iloveeclipse iloveeclipse deleted the issue_210 branch March 28, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bundles to Java 17
1 participant