Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bundles to Java 17 #210

Closed
iloveeclipse opened this issue Mar 23, 2023 · 0 comments · Fixed by #218
Closed

Update bundles to Java 17 #210

iloveeclipse opened this issue Mar 23, 2023 · 0 comments · Fixed by #218
Assignees
@iloveeclipse
Milestone
4.28 M1

Comments

@iloveeclipse
Copy link
Member

There are many bundles in platform which require now Java 17 and so we have bundles that depend on those but still running with Java 11 settings.

We should change that and bump bundle settings / versions etc.

I plan to provide changes.
@iloveeclipse iloveeclipse added this to the 4.28 M1 milestone Mar 23, 2023
@iloveeclipse iloveeclipse self-assigned this Mar 23, 2023
This was referenced Mar 24, 2023
Closed
Closed
iloveeclipse added a commit to iloveeclipse/eclipse.jdt.debug that referenced this issue Mar 27, 2023
@iloveeclipse
Update bundles depending on Java 17 bundles to Java 17
b9fe053 
- used default PDE quickfixes
- updated pom versions manually
- bumped test bundle versions manually
- bumped feature versions manually
- changed buildExtraJAR.xml to use 1.7 as compilation target (jsr14 is
not supported anymore)
- changed buildExtraJAR.xml to use zip instead of jar to create
snippetsupport.jar (avoids creating useless and ever changing manifest)

This commit requires a fix for
eclipse-jdt#217 (because of
the hard coded line 28 in filterDebugEvents() method in
JavaSnippetEditor.java).

Fixes eclipse-jdt#210
@iloveeclipse iloveeclipse mentioned this issue Mar 27, 2023
Merged
iloveeclipse added a commit to iloveeclipse/eclipse.jdt.debug that referenced this issue Mar 28, 2023
@iloveeclipse
Update bundles depending on Java 17 bundles to Java 17
5d599da 
- used default PDE quickfixes
- updated pom versions manually
- bumped test bundle versions manually
- bumped feature versions manually
- changed buildExtraJAR.xml to use 1.7 as compilation target (jsr14 is
not supported anymore)
- changed buildExtraJAR.xml to use zip instead of jar to create
snippetsupport.jar (avoids creating useless and ever changing manifest)

This commit requires a fix for
eclipse-jdt#217 (because of
the hard coded line 28 in filterDebugEvents() method in
JavaSnippetEditor.java).

Fixes eclipse-jdt#210
iloveeclipse added a commit to iloveeclipse/eclipse.jdt.debug that referenced this issue Mar 28, 2023
@iloveeclipse
Update bundles depending on Java 17 bundles to Java 17
4910faa 
- used default PDE quickfixes
- updated pom versions manually
- bumped test bundle versions manually
- bumped feature versions manually
- changed buildExtraJAR.xml to use 1.7 as compilation target (jsr14 is
not supported anymore)
- changed buildExtraJAR.xml to use zip instead of jar to create
snippetsupport.jar (avoids creating useless and ever changing manifest)

Fixes eclipse-jdt#210
iloveeclipse added a commit to iloveeclipse/eclipse.jdt.debug that referenced this issue Mar 28, 2023
@iloveeclipse
Fix warnings in snippeteditor code and re-generate snippetsupport.jar
6bc2fa6 
- updated line reference to actual one
- fixed deprecated warnings after Java 17 update
- fixed resource leak warnings after Java 17 update
- re-generated snippetsupport.jar

See
- eclipse-jdt#210
- eclipse-jdt#217
iloveeclipse added a commit that referenced this issue Mar 28, 2023
@iloveeclipse
Update bundles depending on Java 17 bundles to Java 17
e3fd17c 
- used default PDE quickfixes
- updated pom versions manually
- bumped test bundle versions manually
- bumped feature versions manually
- changed buildExtraJAR.xml to use 1.7 as compilation target (jsr14 is
not supported anymore)
- changed buildExtraJAR.xml to use zip instead of jar to create
snippetsupport.jar (avoids creating useless and ever changing manifest)

Fixes #210
iloveeclipse added a commit that referenced this issue Mar 28, 2023
@iloveeclipse
Fix warnings in snippeteditor code and re-generate snippetsupport.jar
7a8141c 
- updated line reference to actual one
- fixed deprecated warnings after Java 17 update
- fixed resource leak warnings after Java 17 update
- re-generated snippetsupport.jar

See
- #210
- #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
None yet
Projects
None yet
Milestone
4.28 M1
Development

Successfully merging a pull request may close this issue.

Update bundles depending on Java 17 bundles to Java 17 iloveeclipse/eclipse.jdt.debug
1 participant
@iloveeclipse