Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable loading model with references from GitHub #667

Merged
merged 8 commits into from
Nov 4, 2024

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Oct 24, 2024

Description

With the changes in this PR, samm-cli commands no longer only take a local file
name as input for the Aspect Model, but also allow GitHub URLs and Aspect Model
URNs. Resolution from a given GitHub repository can be configured as a
resolution strategy, so it is now also possible to e.g. have an Aspect Model as
a local file that refers to elements hosted on GitHub (via usage of their
namespace; the resolution strategy will then figure out the location of the
corresponding file and retrieve it).

Fixes #474, fixes #664

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit 797c7d1 into eclipse-esmf:main Nov 4, 2024
4 checks passed
@atextor atextor deleted the 474-resolve-from-github branch November 4, 2024 05:04
Copy link

github-actions bot commented Nov 6, 2024

Release v2.9.7 addresses this.

1 similar comment
Copy link

github-actions bot commented Nov 7, 2024

Release v2.9.7 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants