Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Load model with references from github #474

Closed
chris-volk opened this issue Oct 31, 2023 · 2 comments · Fixed by #667
Closed

[Task] Load model with references from github #474

chris-volk opened this issue Oct 31, 2023 · 2 comments · Fixed by #667
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. task

Comments

@chris-volk
Copy link
Contributor

chris-volk commented Oct 31, 2023

As a user of SAMM CLI / ESMF SDK I want to load an Aspect Model from a github url that may include references to other models which are also in github and validate/read it (step 1) as well as make changes to it (step 2)
so that I can work with it quickly without having to worry about manually downloading all references / cloning an entire github repository.

(Additionally, as an ideation, As a modeler I want to add multiple sources to my modeling environment config
so that I can reuse these sources for loading/resolution automatically/more conveniently.)

Example:

In addition to being the basis of making this accessible via Aspect Model Editor (followup story) this issue also serves as a simple demo of the SAMM CLI.

The guideline is that the with the two inputs SAMM CLI + link for Aspect Model on github, the question "is the model valid?" must be answered by an average internet user very fast and easily, minimum number of steps and questions/research (development and documentation to follow the https://en.wikipedia.org/wiki/Principle_of_least_astonishment).

In scope of this issue:

public github repositories with referred namespaces in the correct relative folder structure (meaning: in the same repository)
SDK and SAMM CLI
private github repositories (also correct relative structure), use a library for authentification that works for common private github repositories (note: moved to #665)

Out of scope:

  • git not hosted by github.
  • loading into Aspect Model Editor (this will be a linked issue)
  • uploading (valid) models to github
@chris-volk chris-volk added the acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. label Oct 31, 2023
@chris-volk chris-volk changed the title [Task] Load model with references from github [Task] Load model with references from github / reporting Jan 18, 2024
@chris-volk chris-volk changed the title [Task] Load model with references from github / reporting [Task] Load model with references from github Jan 18, 2024
@chris-volk
Copy link
Contributor Author

chris-volk commented Jan 23, 2024

This should also be available for non-public repositories (if you have access to these). (moved to #665)

ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 19, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 19, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 19, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 19, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 19, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 19, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 19, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 20, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 20, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 20, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 21, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 21, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 27, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 27, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 28, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 28, 2024
ysrbo added a commit to bci-oss/esmf-sdk that referenced this issue Mar 28, 2024
Copy link

github-actions bot commented Nov 7, 2024

Release v2.9.7 addresses this.

@eclipse-esmf eclipse-esmf deleted a comment from github-actions bot Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. task
Projects
None yet
1 participant