Fix handling of spurious wakeups in BufferManagerReadStream #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug #6 Erroneous Timeout: IOP00410037: Timeout while reading data in buffer manager Will adapt tests in follow-up commit Signed-off-by: Andreas Hubold <[email protected]>
EncodingTestBase.ORBDataFake used to provide a hook for tests to run additional code when method fragmentReadTimeout was called. This hook is used to inject code immediately before BufferManagerReadStream starts waiting on the fragmentQueue, for example to simulate Thread interruption. The previous commit changed the code to call method fragmentReadTimeout at a different time, so it cannot be used to change the actual wait in tests anymore. Add new method ORBData#waitNanos that wraps the actual wait call and override it in EncodingTestBase.ORBDataFake to inject the test behaviour. Signed-off-by: Andreas Hubold <[email protected]>
Cousjava
approved these changes
Dec 21, 2018
Closed
|
Dear maintainers, please have a look at this pull request. The bug is really annoying. Would be great to have a fix in a release. |
|
Any news on this one? Would be nice to have it in the next release. |
russgold
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6