FISH-5753 Corba Read Timeout in Buffer Manager #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
|
Jenkins test please |
|
Jenkins test please |
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-5753 Corba Read Timeout in Buffer Manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CORBA occasionally encounters a communication error whilst running clients against our EJBs on the Payara application server, typically when transferring large byte arrays.
Original GlassFish ORB issue: eclipse-ee4j/orb#6
Takes the fix (eclipse-ee4j/orb#41) provided in later versions of CORBA and backports it to our patched fork.
Added a the reproducer from the original issue as an automated test, but left it disabled as from my personal testing I found it typically took around 30-40 minutes before it encountered the reported error against unpatched master.
Important Info
Blockers
Patched Project PR: payara/patched-src-glassfish-corba#13
Testing
New tests
Sample added, but disabled because it takes about 45 minutes to run meaningfully.
Testing Performed
Ran the reproducer against master for about 70 minutes to reproduce twice.
Ran the reproducer against this patched branch for 150 minutes and never got it to happen again.
Testing Environment
Windows 10, JDK 8.
Documentation
N/A
Notes for Reviewers
See description above - the reproducer for this issue taking 30-40 minutes to trip it is a bit pants