chore: update run configs and EDC version #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
approved these changes
Nov 22, 2024
|
|
||
| allprojects { | ||
| apply(plugin = "${group}.edc-build") | ||
|
|
||
| // configure which version of the annotation processor to use. defaults to the same version as the plugin | ||
| configure<org.eclipse.edc.plugins.autodoc.AutodocExtension> { | ||
| outputDirectory.set(project.layout.buildDirectory.asFile) | ||
| processorVersion.set(annotationProcessorVersion) | ||
| processorVersion.set(edcGradlePluginsVersion) |
There was a problem hiding this comment.
this could also be not set, by default it will be same as the project version (0.11.0-SNAPSHOT)
| @@ -1,12 +1,13 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
| <configuration default="false" name="Connector Consumer Corp" type="Application" factoryName="Application"> | |||
| <option name="ALTERNATIVE_JRE_PATH" value="temurin-22" /> | |||
| <option name="ALTERNATIVE_JRE_PATH" value="temurin-21" /> | |||
There was a problem hiding this comment.
why not to set it to 23? LTS is not a requirement for a project that meant to stay up-to-date
wolf4ood
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
updates the JDK version of the runconfigs to a LTS version, updates to use latest EDC snapshots
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.