-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dsp): Add missing notify methods on TransferProcessService
#2661
feat(dsp): Add missing notify methods on TransferProcessService
#2661
Conversation
* @param claimToken the counter-party claim token | ||
* @return a succeeded result if the operation was successful, a failed one otherwise | ||
*/ | ||
ServiceResult<TransferProcess> notifyStarted(TransferStartMessage message, ClaimToken claimToken); |
Check notice
Code scanning / CodeQL
Useless parameter
@@ -40,6 +40,10 @@ | |||
return connectorAddress; | |||
} | |||
|
|||
public String getProcessId() { |
Check notice
Code scanning / CodeQL
Missing Override annotation
* @param claimToken the counter-party claim token | ||
* @return a succeeded result if the operation was successful, a failed one otherwise | ||
*/ | ||
ServiceResult<TransferProcess> notifyTerminated(TransferTerminationMessage message, ClaimToken claimToken); |
Check notice
Code scanning / CodeQL
Useless parameter
* @param claimToken the counter-party claim token | ||
* @return a succeeded result if the operation was successful, a failed one otherwise | ||
*/ | ||
ServiceResult<TransferProcess> notifyCompleted(TransferCompletionMessage message, ClaimToken claimToken); |
Check notice
Code scanning / CodeQL
Useless parameter
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
============================================
- Coverage 64.27% 3.35% -60.93%
- Complexity 0 119 +119
============================================
Files 897 901 +4
Lines 18370 18432 +62
Branches 1094 1095 +1
============================================
- Hits 11808 618 -11190
- Misses 6126 17771 +11645
+ Partials 436 43 -393
... and 615 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
TransferProcessService
TransferProcessService
4e0c371
to
0394189
Compare
0394189
to
0aa6a01
Compare
0aa6a01
to
706a74a
Compare
706a74a
to
d92af19
Compare
d92af19
to
3b3bb3d
Compare
3b3bb3d
to
fa97d47
Compare
What this PR changes/adds
Adds missing methods on
TransferProcessService
that will permit the DSP controller to ingest an incomingRemoteMessage
to the serviceWhy it does that
refactoring
Further notes
processId
to theTransferProcess*Message
s through aTransferRemoteMessage
interfaceLinked Issue(s)
Closes #2651
Checklist
no-changelog
)