Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataspace protocol: Add missing notify methods on TransferProcess services #2651

Closed
Tracked by #2429
ndr-brt opened this issue Mar 29, 2023 · 0 comments · Fixed by #2661
Closed
Tracked by #2429

dataspace protocol: Add missing notify methods on TransferProcess services #2651

ndr-brt opened this issue Mar 29, 2023 · 0 comments · Fixed by #2661
Assignees
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Mar 29, 2023

Feature Request

Add methods on TransferProcessService that will permit the (currently called) message handlers to being able to apply the needed state transition.

e.g. currently in TransferProcessService there's the notifyStarted method, that will be called when a TransferStartMessage is received from a provider, and the referred TransferProcess state need to be changed accordingly.

Adding the notify prefix will help to distinguish methods where actually an action is performed on the connector to the ones that represent an action taken on the counter-part and to keep the present tense (typical for an action/command).
e.g. terminate/notifyTerminated .

Which Areas Would Be Affected?

transfer process

Why Is the Feature Desired?

cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant