Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OAuth flow for Gitlab SaaS #21435

Closed
vinokurig opened this issue May 31, 2022 · 2 comments
Closed

Support OAuth flow for Gitlab SaaS #21435

vinokurig opened this issue May 31, 2022 · 2 comments
Assignees
@vinokurig
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@vinokurig
Copy link
Contributor

Is your task related to a problem? Please describe

Che supports Gitlab onpremises version only. Add the Saas version suport.

Describe the solution you'd like

Add the Saas version suport.

Describe alternatives you've considered

No response

Additional context

#20583
@vinokurig vinokurig added the kind/task Internal things, technical debt, and to-do tasks to be performed. label May 31, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 31, 2022
@vinokurig vinokurig self-assigned this May 31, 2022
@dkwon17 dkwon17 added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 31, 2022
@vinokurig vinokurig mentioned this issue Jun 1, 2022
Closed
11 tasks
@vinokurig
Copy link
Contributor Author

@benoitf @l0rd
I've tried to apply the gitlab oauth secret as described here with the che.eclipse.org/scm-server-endpoint as https://gitlab.com and it worked.
So I believe that we can consider that we do support gitlab SAAS oAuth2. The only thing is that in the current state Che doesn't support GitLab SAAS and on-premises versions at the same time. We can configure only SAAS or on-premises version with the current oAuth provider. So do we need to support them at the same time? WDYT?

@svor svor mentioned this issue Jun 6, 2022
Closed
64 tasks
@l0rd
Copy link
Contributor

l0rd commented Jun 7, 2022

@vinokurig thanks for investigating.
We can ignore supporting both SaaS and on-prem at the same time.
Please check/update the documentation (we should mention that gitlab.com is supported) before closing this issue.

@vinokurig vinokurig mentioned this issue Jun 10, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@l0rd @vinokurig @che-bot @dkwon17