Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update GitLab configuration page #2368

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: Update GitLab configuration page #2368

merged 1 commit into from
Jun 13, 2022

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jun 10, 2022

Signed-off-by: Igor Vinokur [email protected]

What does this pull request change

Update GitLab oAuth configuration page.
screenshot-0 0 0 0_4000-2022 06 10-09_27_42

What issues does this pull request fix or reference

fixes eclipse-che/che#21435

Specify the version of the product this pull request applies to

Pull request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@vinokurig vinokurig requested review from rkratky, themr0c and a team as code owners June 10, 2022 06:35
@vinokurig vinokurig requested review from amisevsk and removed request for a team June 10, 2022 06:35
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@themr0c
Copy link
Contributor

themr0c commented Jun 10, 2022

Is the feature for Che 7.50, or does it work already on Che 7.46?

@themr0c
Copy link
Contributor

themr0c commented Jun 10, 2022

In the corresponding issue I see:

We can configure only SAAS or on-premises version with the current oAuth provider.

I believe we should add this information in the docs as well. Something like:

To enable users to work with a remote Git repository that is hosted using one GitLab instance:

@vinokurig
Copy link
Contributor Author

vinokurig commented Jun 10, 2022

Is the feature for Che 7.50, or does it work already on Che 7.46?

It already works since the gitlab oAuth is added

@vinokurig
Copy link
Contributor Author

@themr0c

In the corresponding issue I see:

We can configure only SAAS or on-premises version with the current oAuth provider.

I believe we should add this information in the docs as well. Something like:

To enable users to work with a remote Git repository that is hosted using one GitLab instance:

I think from this PR it is clear what to do if admin wants to use the SAAS OR onpremises version. I don't think it is a good idea to describe that we doesn't support using both instances as it would only confue the reader.

@themr0c themr0c added this to the 7.46 milestone Jun 13, 2022
@themr0c themr0c merged commit 31431c7 into master Jun 13, 2022
@themr0c themr0c deleted the che-21435 branch June 13, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants