Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for GitLab SAAS oAuth2 #1394

Closed
wants to merge 1 commit into from
Closed

Conversation

vinokurig
Copy link
Contributor

Signed-off-by: Igor Vinokur [email protected]

What does this PR do?

Mount GitLab Saas oAuth2 specific config from the oauth secret.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#21435

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image quay.io/ivinokur/che-operator:next \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha
Copy link
Contributor

tolusha commented Jun 2, 2022

Something wrong with dashboard

Starting Dashboard backend server...
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module 'p-limit'
Require stack:
- /backend/server/backend.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.75471 (/backend/server/backend.js:8:511823)
    at __webpack_require__ (/backend/server/backend.js:8:637401)
    at Object.26005 (/backend/server/backend.js:2:302919)
    at __webpack_require__ (/backend/server/backend.js:8:637401)
    at Object.80922 (/backend/server/backend.js:2:297270)
    at __webpack_require__ (/backend/server/backend.js:8:637401) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/backend/server/backend.js' ]
}
Dashboard backend server is stopped.

@tolusha
Copy link
Contributor

tolusha commented Jun 2, 2022

/retest

@vinokurig vinokurig marked this pull request as draft June 2, 2022 13:38
@tolusha
Copy link
Contributor

tolusha commented Jun 3, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-devworkspace-happy-path 2bbffc8 link true /test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vinokurig vinokurig closed this Jun 7, 2022
@vinokurig vinokurig deleted the che-21435 branch June 7, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants