feat: spec.devEnvironments.podSchedulerName in CR #1587

dkwon17 · 2022-12-22T21:20:32Z

What does this PR do?

New, rebased PR that replaces #1565

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

Can be tested by running and following snippet, and then following the same steps from #1565

cat > /tmp/cs.yaml <<EOF
apiVersion:  operators.coreos.com/v1alpha1
kind:         CatalogSource
metadata:
  name:         eclipse-che
  namespace:    eclipse-che
spec:
  image:       quay.io/dkwon17/eclipse-che-olm-catalog:schedulerName
  sourceType:  grpc
  updateStrategy:
    registryPoll:
      interval: 5m
EOF

chectl server:deploy \
    --che-operator-image=quay.io/dkwon17/che-operator:schedulerName \
    --installer=olm \
    --platform=openshift \
    --catalog-source-yaml /tmp/cs.yaml \
    --olm-channel=next \
    --package-manifest-name=eclipse-che

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: David Kwon <[email protected]>

Signed-off-by: Anatolii Bazko <[email protected]>

openshift-ci · 2022-12-23T15:26:45Z

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v11-devworkspace-happy-path	`85aa5c8`	link	true	`/test v11-devworkspace-happy-path`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-12-23T15:31:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

devstudio-release · 2022-12-23T16:18:45Z

Build 3.5 :: operator_3.x/158: Console, Changes, Git Data

devstudio-release · 2022-12-23T16:20:16Z

Build 3.5 :: sync-to-downstream_3.x/1804: Console, Changes, Git Data

devstudio-release · 2022-12-23T16:20:52Z

Build 3.5 :: get-sources-rhpkg-container-build_3.x/1770: Console, Changes, Git Data

devstudio-release · 2022-12-23T16:36:56Z

Build 3.5 :: push-latest-container-to-quay_3.x/1394: Console, Changes, Git Data

devstudio-release · 2022-12-23T16:37:44Z

Build 3.5 :: update-digests_3.x/1652: Console, Changes, Git Data

devstudio-release · 2022-12-23T16:37:44Z

Build 3.5 :: push-latest-container-to-quay_3.x/1394:

Copied: devspaces-rhel8-operator; /job/DS_CI/job/update-digests_3.x triggered;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

devstudio-release · 2022-12-23T16:37:45Z

Build 3.5 :: copyIIBsToQuay/499: Console, Changes, Git Data

devstudio-release · 2022-12-23T16:37:46Z

Build 3.5 :: get-sources-rhpkg-container-build_3.x/1770:

devspaces-operator : 3.x :: Build 49782007 : quay.io/devspaces/devspaces-rhel8-operator:3.5-6
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/1394 triggered

devstudio-release · 2022-12-23T16:37:52Z

Build 3.5 :: sync-to-downstream_3.x/1804:

Build container: devspaces-operator synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1770 triggered;

devstudio-release · 2022-12-23T16:37:53Z

Build 3.5 :: operator_3.x/158:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1804 triggered

devstudio-release · 2022-12-23T16:38:19Z

Build 3.5 :: operator-bundle_3.x/719: Console, Changes, Git Data

devstudio-release · 2022-12-23T16:45:58Z

Build 3.5 :: sync-to-downstream_3.x/1805: Console, Changes, Git Data

devstudio-release · 2022-12-25T22:46:59Z

Build 3.5 :: get-sources-rhpkg-container-build_3.x/1792:

devspaces-operator-bundle : 3.x :: Build 49792327 : quay.io/devspaces/devspaces-operator-bundle:3.5-20
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/1414 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.5-4
- quay.io/devspaces/configbump-rhel8:3.5-3
- quay.io/devspaces/dashboard-rhel8:3.5-3
- quay.io/devspaces/devfileregistry-rhel8:3.5-10
- quay.io/devspaces/devspaces-rhel8-operator:3.5-7
- quay.io/devspaces/idea-rhel8:3.5-7
- quay.io/devspaces/machineexec-rhel8:3.5-3
- quay.io/devspaces/pluginregistry-rhel8:3.5-5
- quay.io/devspaces/server-rhel8:3.5-5
- quay.io/devspaces/theia-endpoint-rhel8:3.5-1
- quay.io/devspaces/theia-rhel8:3.5-1
- quay.io/devspaces/traefik-rhel8:3.5-3
- quay.io/devspaces/udi-rhel8:3.5-5
= registry.redhat.io/devworkspace/devworkspace-rhel8-operator:0.17-2
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.11.0-202212070335.p0.ga805ba5.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.11.0-202212070335.p0.gaad1b28.assembly.stream
= registry.redhat.io/rhel8/postgresql-13:1-91.1669834637
= registry.redhat.io/rhel8/postgresql-96:1-159
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.6-994

devstudio-release · 2022-12-25T22:51:35Z

Build 3.5 :: sync-to-downstream_3.x/1829:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1792 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2022-12-25T22:51:36Z

Build 3.5 :: operator-bundle_3.x/725:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1829 triggered

devstudio-release · 2022-12-25T22:52:59Z

Build 3.5 :: dsc_3.x/518: Console, Changes, Git Data

devstudio-release · 2022-12-25T23:00:28Z

Build 3.5 :: dsc_3.x/518:

3.5.0 CI

devstudio-release · 2022-12-25T23:03:05Z

Build 3.5 :: copyIIBsToQuay/531:

arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.5-20
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.18-1
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-403964-402447-ppc64le
  + quay.io/devspaces/iib:3.5-v4.11-404055-402443-ppc64le
  + quay.io/devspaces/iib:3.5-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.5-v4.10-404054-402439-ppc64le
  + quay.io/devspaces/iib:3.5-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-403964-402447-s390x
  + quay.io/devspaces/iib:3.5-v4.11-404055-402443-s390x
  + quay.io/devspaces/iib:3.5-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.5-v4.10-404054-402439-s390x
  + quay.io/devspaces/iib:3.5-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.5-v4.12-403964-402447-x86_64
  + quay.io/devspaces/iib:3.5-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.5-v4.11-404055-402443-x86_64
  + quay.io/devspaces/iib:3.5-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.5-v4.10-404054-402439-x86_64
  + quay.io/devspaces/iib:3.5-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

devstudio-release · 2022-12-26T22:35:07Z

Build 3.5 :: operator-bundle_3.x/726: Console, Changes, Git Data

devstudio-release · 2022-12-26T22:38:31Z

Build 3.5 :: sync-to-downstream_3.x/1834: Console, Changes, Git Data

devstudio-release · 2022-12-26T22:39:19Z

Build 3.5 :: get-sources-rhpkg-container-build_3.x/1794: Console, Changes, Git Data

devstudio-release · 2022-12-26T22:43:53Z

Build 3.5 :: push-latest-container-to-quay_3.x/1416: Console, Changes, Git Data

devstudio-release · 2022-12-26T22:46:39Z

Build 3.5 :: copyIIBsToQuay/533: Console, Changes, Git Data

devstudio-release · 2022-12-26T22:46:41Z

Build 3.5 :: push-latest-container-to-quay_3.x/1416:

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

devstudio-release · 2022-12-26T22:48:35Z

Build 3.5 :: get-sources-rhpkg-container-build_3.x/1794:

devspaces-operator-bundle : 3.x :: Build 49801522 : quay.io/devspaces/devspaces-operator-bundle:3.5-21
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/1416 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.5-4
- quay.io/devspaces/configbump-rhel8:3.5-3
- quay.io/devspaces/dashboard-rhel8:3.5-3
- quay.io/devspaces/devfileregistry-rhel8:3.5-11
- quay.io/devspaces/devspaces-rhel8-operator:3.5-7
- quay.io/devspaces/idea-rhel8:3.5-7
- quay.io/devspaces/machineexec-rhel8:3.5-3
- quay.io/devspaces/pluginregistry-rhel8:3.5-5
- quay.io/devspaces/server-rhel8:3.5-5
- quay.io/devspaces/theia-endpoint-rhel8:3.5-1
- quay.io/devspaces/theia-rhel8:3.5-1
- quay.io/devspaces/traefik-rhel8:3.5-3
- quay.io/devspaces/udi-rhel8:3.5-5
= registry.redhat.io/devworkspace/devworkspace-rhel8-operator:0.17-2
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.11.0-202212070335.p0.ga805ba5.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.11.0-202212070335.p0.gaad1b28.assembly.stream
= registry.redhat.io/rhel8/postgresql-13:1-91.1669834637
= registry.redhat.io/rhel8/postgresql-96:1-159
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.6-994

devstudio-release · 2022-12-26T22:48:50Z

Build 3.5 :: sync-to-downstream_3.x/1834:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1794 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2022-12-26T22:48:51Z

Build 3.5 :: operator-bundle_3.x/726:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1834 triggered

devstudio-release · 2022-12-26T22:50:11Z

Build 3.5 :: dsc_3.x/519: Console, Changes, Git Data

devstudio-release · 2022-12-26T22:59:31Z

Build 3.5 :: dsc_3.x/519:

3.5.0 CI

devstudio-release · 2022-12-27T22:35:32Z

Build 3.5 :: operator-bundle_3.x/727: Console, Changes, Git Data

devstudio-release · 2022-12-27T22:38:52Z

Build 3.5 :: sync-to-downstream_3.x/1840: Console, Changes, Git Data

devstudio-release · 2022-12-27T22:39:19Z

Build 3.5 :: get-sources-rhpkg-container-build_3.x/1796: Console, Changes, Git Data

devstudio-release · 2022-12-27T22:44:07Z

Build 3.5 :: push-latest-container-to-quay_3.x/1418: Console, Changes, Git Data

devstudio-release · 2022-12-27T22:46:52Z

Build 3.5 :: copyIIBsToQuay/535: Console, Changes, Git Data

devstudio-release · 2022-12-27T22:46:54Z

Build 3.5 :: push-latest-container-to-quay_3.x/1418:

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

devstudio-release · 2022-12-27T22:48:35Z

Build 3.5 :: get-sources-rhpkg-container-build_3.x/1796:

devspaces-operator-bundle : 3.x :: Build 49805712 : quay.io/devspaces/devspaces-operator-bundle:3.5-22
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/1418 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.5-4
- quay.io/devspaces/configbump-rhel8:3.5-3
- quay.io/devspaces/dashboard-rhel8:3.5-3
- quay.io/devspaces/devfileregistry-rhel8:3.5-12
- quay.io/devspaces/devspaces-rhel8-operator:3.5-7
- quay.io/devspaces/idea-rhel8:3.5-7
- quay.io/devspaces/machineexec-rhel8:3.5-3
- quay.io/devspaces/pluginregistry-rhel8:3.5-5
- quay.io/devspaces/server-rhel8:3.5-5
- quay.io/devspaces/theia-endpoint-rhel8:3.5-1
- quay.io/devspaces/theia-rhel8:3.5-1
- quay.io/devspaces/traefik-rhel8:3.5-3
- quay.io/devspaces/udi-rhel8:3.5-5
= registry.redhat.io/devworkspace/devworkspace-rhel8-operator:0.17-2
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.11.0-202212070335.p0.ga805ba5.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.11.0-202212070335.p0.gaad1b28.assembly.stream
= registry.redhat.io/rhel8/postgresql-13:1-91.1669834637
= registry.redhat.io/rhel8/postgresql-96:1-159
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.6-994

devstudio-release · 2022-12-27T22:48:45Z

Build 3.5 :: sync-to-downstream_3.x/1840:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1796 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2022-12-27T22:48:47Z

Build 3.5 :: operator-bundle_3.x/727:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1840 triggered

devstudio-release · 2022-12-27T22:50:18Z

Build 3.5 :: dsc_3.x/520: Console, Changes, Git Data

devstudio-release · 2022-12-27T22:58:20Z

Build 3.5 :: dsc_3.x/520:

3.5.0 CI

dkwon17 requested review from nickboldt, tolusha, AndrienkoAleksandr and flacatus as code owners December 22, 2022 21:20

dkwon17 force-pushed the schedulerName-new branch from 352519b to 6762940 Compare December 22, 2022 22:08

dkwon17 and others added 3 commits December 23, 2022 16:15

feat: spec.devEnvironments.podSchedulerName in CR

16af8d4

Signed-off-by: David Kwon <[email protected]>

Run make update-dev-resources

71f63c3

Signed-off-by: David Kwon <[email protected]>

Update dev resources

85aa5c8

Signed-off-by: Anatolii Bazko <[email protected]>

tolusha force-pushed the schedulerName-new branch from 6762940 to 85aa5c8 Compare December 23, 2022 14:17

tolusha approved these changes Dec 23, 2022

View reviewed changes

openshift-ci bot assigned tolusha Dec 23, 2022

openshift-ci bot added the lgtm label Dec 23, 2022

ibuziuk approved these changes Dec 23, 2022

View reviewed changes

openshift-ci bot assigned ibuziuk Dec 23, 2022

dkwon17 merged commit 4774568 into eclipse-che:main Dec 23, 2022

che-bot added this to the 7.59 milestone Dec 23, 2022

tolusha mentioned this pull request Dec 28, 2022

Sprint 229 eclipse-che/che#21864

Closed

82 tasks

dkwon17 mentioned this pull request Jan 4, 2023

Allow specify workspace pods schedulerName via CheCluster spec eclipse-che/che#21803

Closed

feat: spec.devEnvironments.podSchedulerName in CR #1587

feat: spec.devEnvironments.podSchedulerName in CR #1587

Conversation

dkwon17 commented Dec 22, 2022

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

openshift-ci bot commented Dec 23, 2022

openshift-ci bot commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 23, 2022

devstudio-release commented Dec 25, 2022

devstudio-release commented Dec 25, 2022

devstudio-release commented Dec 25, 2022

devstudio-release commented Dec 25, 2022

devstudio-release commented Dec 25, 2022

devstudio-release commented Dec 25, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 26, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022

devstudio-release commented Dec 27, 2022