Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specify workspace pods schedulerName via CheCluster spec #21803

Closed
ibuziuk opened this issue Nov 3, 2022 · 2 comments
Closed

Allow specify workspace pods schedulerName via CheCluster spec #21803

ibuziuk opened this issue Nov 3, 2022 · 2 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Nov 3, 2022

Is your task related to a problem? Please describe

There are some specialized Kubernetes scheduler that can improve workspaces performances. One example is Portworx Stork. To use those schedulers pod should reference them in the PodSpec.schedulerName field.

Describe the solution you'd like

Now it is possible to set arbitrary fields of the workspace Pod and containers and we need a dedicated CR property in Eclipse Che operator for setting the schedulerName:

spec.DevEnvironments.defaultPodSchedularName

under the hood, Che operator would propagate this value to the managed DWOC, and set correct value for schedulerName e.g. config.workspace.podSecurityContext.schedulerName:

Describe alternatives you've considered

Release Notes Text

Before, the Kubernetes scheduler that managed Che workspaces was always the default one. Now Che administrators can specify an alternative Kubernetes scheduler using the CheCluster custom resource.

@ibuziuk ibuziuk added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Nov 3, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 3, 2022
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 3, 2022
@dkwon17
Copy link
Contributor

dkwon17 commented Nov 12, 2022

Hi @ibuziuk , I made a PR on the DWO side: devfile/devworkspace-operator#976, but instead of config.workspace.podSecurityContext.schedulerName, the PR introduces config.workspace.schedulerName, because schedulerName is not part of a pod's podSecurityContext (DWOC types, corev1 types), WDYT?

@dkwon17
Copy link
Contributor

dkwon17 commented Jan 4, 2023

Fixed thanks to eclipse-che/che-operator#1587

The schedulerName for workspace pods is now configured within spec.devEnvironments.podSchedulerName in the Che CR

@dkwon17 dkwon17 closed this as completed Jan 4, 2023
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jan 5, 2023
@l0rd l0rd added this to the 7.59 milestone Jan 5, 2023
@l0rd l0rd changed the title Specify workspace pod schedulerName as CR property Allow specify workspace pods schedulerName via CheCluster spec Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Projects
None yet
Development

No branches or pull requests

4 participants