22045 feature implement quarkus smoke test as prcheck #862

ScrewTSW · 2023-07-13T13:43:10Z

What does this PR do?

eclipse-che/che#22045
follow-up to #834

What issues does this PR fix or reference?

reference #834

Is it tested? How?

reference #834

Release Notes

N/A

Docs PR

N/A

che-bot · 2023-07-13T13:43:22Z

Click here to review and test in web IDE:

github-actions · 2023-07-13T14:00:50Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-862

che-bot · 2023-07-13T14:30:28Z

Click here to review and test in web IDE:

github-actions · 2023-07-15T00:05:05Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-862

Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>

github-actions · 2023-07-19T12:49:57Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-862

github-actions · 2023-07-19T12:51:47Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-862

github-actions · 2023-07-19T12:53:08Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-862

github-actions · 2023-07-19T13:03:28Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-862

codecov · 2023-07-19T14:01:29Z

Codecov Report

Merging #862 (d51cff9) into main (58cdd35) will not change coverage.
The diff coverage is n/a.

❗ Current head d51cff9 differs from pull request most recent head f29cf11. Consider uploading reports for the commit f29cf11 to get more accurate results

@@           Coverage Diff           @@
##             main     #862   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files         347      347           
  Lines       35874    35874           
  Branches     2230     2230           
=======================================
  Hits        29271    29271           
  Misses       6581     6581           
  Partials       22       22

Flag	Coverage Δ
unittests	`81.59% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

ibuziuk · 2023-07-19T14:09:09Z

.ci/oci-dashboard-happy-path.sh

+
+export WORKDIR=${WORKDIR:-"${SCRIPT_DIR}/workdir"}
+export CHE_NAMESPACE=${CHE_NAMESPACE:-"eclipse-che"}
+export HAPPY_PATH_POD_NAME='happy-path-che'


cc: @dmytro-ndp is it ok to use happy-path naming or we should stick to smoke test
just want to avoid confusion in the scripts

good catch, @ibuziuk

+1 to use smoke-test naming, because it would help to avoid wrong expectations from test result

I replaced it at as many places as I was able to confidently do.

.ci/resources/users.htpasswd

.ci/resources/pod-che-smoke-test.yaml

.ci/resources/cluster-oauth-patch.json

ibuziuk

a few minor comments, happy path naming works for me just want to make sure the rest of the team has no problem with this

akurinnoy

LGTM

…s possible Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>

github-actions · 2023-07-19T17:34:23Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-862

ScrewTSW · 2023-07-19T18:27:34Z

/retest

ScrewTSW · 2023-07-19T18:49:34Z

/retest

ScrewTSW · 2023-07-19T22:30:19Z

/retest

ScrewTSW · 2023-07-19T22:31:24Z

/test v11-dashboard-happy-path

dmytro-ndp · 2023-07-20T07:36:24Z

@ScrewTSW : what is the command to trigger smoke test manually in PR?
Is it still /test v11-dashboard-happy-path ?

dmytro-ndp · 2023-07-20T07:41:06Z

@ScrewTSW : it would also be great to make sure PR image quay.io/eclipse/che-dashboard:pr-862 has been applied properly to testing Eclipse Che when run smoke test.
Is this information available in test run log?

ScrewTSW · 2023-07-20T07:41:40Z

@ScrewTSW : it would also be great to make sure PR image quay.io/eclipse/che-dashboard:pr-862 has been applied properly to testing Eclipse Che when run smoke test.
Is this information available in test run log?

that image doesn't get used at all. The test uses the image that's built locally on PROW-CI

dmytro-ndp · 2023-07-20T09:58:11Z

@ScrewTSW : thanks for explanation!

I have actually found the way to check it - from events.log, e.g. https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/eclipse-che_che-dashboard/862/pull-ci-eclipse-che-che-dashboard-main-v11-dashboard-happy-path/1681793899066036224/artifacts/dashboard-happy-path/test/artifacts/eclipse-che-info/events.log

message: Successfully pulled image "registry.build03.ci.openshift.org/ci-op-00jbrd1b/pipeline@sha256:ade5359bb697fb638440039d90e80950878d95c846143cb045883eb5d79ffdd4"

dmytro-ndp

Test PR check [1], [2] has correctly executed test steps from target issue [3].

Good job, @ScrewTSW !

[1] https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/eclipse-che_che-dashboard/862/pull-ci-eclipse-che-che-dashboard-main-v11-dashboard-happy-path/1681793899066036224/artifacts/dashboard-happy-path/test/artifacts/e2e/output.webm

output (30).webm

[2] https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/eclipse-che_che-dashboard/862/pull-ci-eclipse-che-che-dashboard-main-v11-dashboard-happy-path/1681793899066036224/artifacts/dashboard-happy-path/test/build-log.txt

gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com_gcs_origin-ci-test_pr-logs_pull_eclipse-che_che-dashboard_862_pull-ci-eclipse-che-che-dashboard-main-v11-dashboard-happy-path_1681793899066036224_artifacts_dashboard-happy-path_test_build-log.txt

[3] eclipse-che/che#22045

openshift-ci · 2023-07-20T12:12:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dmytro-ndp, ibuziuk, olexii4, ScrewTSW

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

devstudio-release · 2023-07-23T08:49:22Z

Build 3.9 :: dashboard_3.x/287: Console, Changes, Git Data

devstudio-release · 2023-07-23T08:53:55Z

Build 3.9 :: sync-to-downstream_3.x/3805: Console, Changes, Git Data

devstudio-release · 2023-07-23T08:59:57Z

Build 3.9 :: get-sources-rhpkg-container-build_3.x/3654: Console, Changes, Git Data

devstudio-release · 2023-07-23T09:26:30Z

Build 3.9 :: push-latest-container-to-quay_3.x/2752: Console, Changes, Git Data

devstudio-release · 2023-07-23T09:30:07Z

Build 3.9 :: get-sources-rhpkg-container-build_3.x/3654:

dashboard : 3.x :: Build 54128396 : quay.io/devspaces/dashboard-rhel8:3.9-2
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/2752 triggered

devstudio-release · 2023-07-23T09:30:10Z

Build 3.9 :: dashboard_3.x/287:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3805 triggered

ScrewTSW requested review from akurinnoy, olexii4 and ibuziuk as code owners July 13, 2023 13:43

olexii4 mentioned this pull request Jul 17, 2023

22045 feature implement quarkus smoke test as prcheck #865

Closed

ScrewTSW force-pushed the 22045-feature-implement-quarkus-smoke-test-as-prcheck branch from 6acbe7f to 1bb1229 Compare July 19, 2023 12:32

ScrewTSW added 3 commits July 19, 2023 14:35

Updated patch yamls, rewriting logic of oci-dashboard-happy-path.sh

8b32ee9

Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>

Adding prod-che-smoke-test.yaml pod description

632f7c4

Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>

Added oauth provision and executing tests from image

b4aeaa9

Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>

ScrewTSW force-pushed the 22045-feature-implement-quarkus-smoke-test-as-prcheck branch from 1bb1229 to b4aeaa9 Compare July 19, 2023 12:36

Updating logging, archiving che-patch-cr.yaml

d51cff9

Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>

ScrewTSW force-pushed the 22045-feature-implement-quarkus-smoke-test-as-prcheck branch from b1090c6 to d51cff9 Compare July 19, 2023 12:48

ibuziuk reviewed Jul 19, 2023

View reviewed changes

ibuziuk requested a review from dmytro-ndp July 19, 2023 14:09

ibuziuk reviewed Jul 19, 2023

View reviewed changes

.ci/resources/users.htpasswd Outdated Show resolved Hide resolved

ibuziuk reviewed Jul 19, 2023

View reviewed changes

.ci/resources/pod-che-smoke-test.yaml Outdated Show resolved Hide resolved

ibuziuk reviewed Jul 19, 2023

View reviewed changes

.ci/resources/cluster-oauth-patch.json Outdated Show resolved Hide resolved

ibuziuk approved these changes Jul 19, 2023

View reviewed changes

openshift-ci bot assigned ibuziuk Jul 19, 2023

openshift-ci bot added the lgtm label Jul 19, 2023

olexii4 approved these changes Jul 19, 2023

View reviewed changes

openshift-ci bot assigned olexii4 Jul 19, 2023

akurinnoy approved these changes Jul 19, 2023

View reviewed changes

openshift-ci bot assigned akurinnoy Jul 19, 2023

Fixing missing new lines, renaming as much of happy-path references a…

f29cf11

…s possible Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>

openshift-ci bot removed the lgtm label Jul 19, 2023

dmytro-ndp approved these changes Jul 20, 2023

View reviewed changes

openshift-ci bot assigned dmytro-ndp Jul 20, 2023

openshift-ci bot added the lgtm label Jul 20, 2023

ibuziuk merged commit aa83f01 into main Jul 20, 2023

ibuziuk deleted the 22045-feature-implement-quarkus-smoke-test-as-prcheck branch July 20, 2023 12:15

ScrewTSW mentioned this pull request Jul 27, 2023

Increate IdentityProvider set-up timeout, decrease check frequency #876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

22045 feature implement quarkus smoke test as prcheck #862

22045 feature implement quarkus smoke test as prcheck #862

ScrewTSW commented Jul 13, 2023

che-bot commented Jul 13, 2023

github-actions bot commented Jul 13, 2023

che-bot commented Jul 13, 2023

github-actions bot commented Jul 15, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

codecov bot commented Jul 19, 2023 •

edited

Loading

ibuziuk Jul 19, 2023

dmytro-ndp Jul 19, 2023

ScrewTSW Jul 19, 2023

ibuziuk left a comment

akurinnoy left a comment

github-actions bot commented Jul 19, 2023

ScrewTSW commented Jul 19, 2023

ScrewTSW commented Jul 19, 2023

ScrewTSW commented Jul 19, 2023

ScrewTSW commented Jul 19, 2023

dmytro-ndp commented Jul 20, 2023

dmytro-ndp commented Jul 20, 2023

ScrewTSW commented Jul 20, 2023 •

edited

Loading

dmytro-ndp commented Jul 20, 2023

dmytro-ndp left a comment

openshift-ci bot commented Jul 20, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

22045 feature implement quarkus smoke test as prcheck #862

22045 feature implement quarkus smoke test as prcheck #862

Conversation

ScrewTSW commented Jul 13, 2023

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

che-bot commented Jul 13, 2023

github-actions bot commented Jul 13, 2023

che-bot commented Jul 13, 2023

github-actions bot commented Jul 15, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

codecov bot commented Jul 19, 2023 • edited Loading

Codecov Report

ibuziuk Jul 19, 2023

Choose a reason for hiding this comment

dmytro-ndp Jul 19, 2023

Choose a reason for hiding this comment

ScrewTSW Jul 19, 2023

Choose a reason for hiding this comment

ibuziuk left a comment

Choose a reason for hiding this comment

akurinnoy left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 19, 2023

ScrewTSW commented Jul 19, 2023

ScrewTSW commented Jul 19, 2023

ScrewTSW commented Jul 19, 2023

ScrewTSW commented Jul 19, 2023

dmytro-ndp commented Jul 20, 2023

dmytro-ndp commented Jul 20, 2023

ScrewTSW commented Jul 20, 2023 • edited Loading

dmytro-ndp commented Jul 20, 2023

dmytro-ndp left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 20, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

codecov bot commented Jul 19, 2023 •

edited

Loading

ScrewTSW commented Jul 20, 2023 •

edited

Loading