Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eclipse/che Quarkus smoke test as prcheck #834

Conversation

ScrewTSW
Copy link
Member

@ScrewTSW ScrewTSW commented Jun 7, 2023

What does this PR do?

  • Replaces original dashboard-happy-path with Quarkus smoke test as official PRCheck test
  • Adds video recording and screenshots to artifacts

What issues does this PR fix or reference?

eclipse-che/che#22045

Is it tested? How?

IN-PROGRESS

Release Notes

Developed on Che Dogfooding instance as part of DevToolsWeek agenda
IN-PROGRESS

Docs PR

N/A

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ScrewTSW

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Jun 7, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Jun 7, 2023

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

@ScrewTSW: The following commands are available to trigger required jobs:

  • /test v11-dashboard-happy-path
  • /test v11-e2e-puppeteer
  • /test v11-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-eclipse-che-che-dashboard-main-v11-dashboard-happy-path
  • pull-ci-eclipse-che-che-dashboard-main-v11-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from 5d02cab to be38bc2 Compare June 7, 2023 14:21
@che-bot
Copy link
Contributor

che-bot commented Jun 7, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Jun 7, 2023

/test v11-dashboard-happy-path

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #834 (be38bc2) into main (f1b86db) will increase coverage by 2.74%.
The diff coverage is 73.37%.

❗ Current head be38bc2 differs from pull request most recent head c164166. Consider uploading reports for the commit c164166 to get more accurate results

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   78.88%   81.62%   +2.74%     
==========================================
  Files         329      349      +20     
  Lines       32560    35552    +2992     
  Branches     2017     2232     +215     
==========================================
+ Hits        25684    29019    +3335     
+ Misses       6817     6510     -307     
+ Partials       59       23      -36     
Flag Coverage Δ
unittests 81.62% <73.37%> (+2.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rd-frontend/src/components/DevfileEditor/index.tsx 43.68% <0.00%> (ø)
...dashboard-frontend/src/services/bootstrap/index.ts 0.00% <0.00%> (ø)
...-frontend/src/services/devfileApi/devfile/index.ts 0.00% <0.00%> (ø)
...ontend/src/services/devfileApi/devfile/metadata.ts 0.00% <0.00%> (ø)
.../dashboard-frontend/src/store/SanityCheck/index.ts 51.26% <0.00%> (ø)
...rvices/dashboard-backend-client/devWorkspaceApi.ts 52.17% <20.00%> (-6.65%) ⬇️
...s/GetStarted/GetStartedTab/ImportFromGit/index.tsx 95.87% <33.33%> (-0.09%) ⬇️
...ckend/src/devworkspaceClient/services/podmanApi.ts 38.53% <38.53%> (ø)
packages/dashboard-frontend/src/Routes/index.tsx 90.76% <50.00%> (+7.67%) ⬆️
...tStartedTab/ImportFromGit/GitRepoLocationInput.tsx 77.62% <50.00%> (-1.67%) ⬇️
... and 23 more

... and 87 files with indirect coverage changes

@che-bot
Copy link
Contributor

che-bot commented Jun 8, 2023

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Jun 8, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Jun 8, 2023

/test v11-dashboard-happy-path

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from 83d2b71 to edb028b Compare June 29, 2023 13:13
@che-bot
Copy link
Contributor

che-bot commented Jun 29, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from edb028b to 8081695 Compare July 3, 2023 07:57
@che-bot
Copy link
Contributor

che-bot commented Jul 3, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from 8081695 to 6792f7d Compare July 3, 2023 08:11
@che-bot
Copy link
Contributor

che-bot commented Jul 3, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from 6792f7d to 49732ea Compare July 3, 2023 08:28
@che-bot
Copy link
Contributor

che-bot commented Jul 3, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from 49732ea to 6564af9 Compare July 3, 2023 08:29
@che-bot
Copy link
Contributor

che-bot commented Jul 3, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from 6564af9 to 3e2eaf6 Compare July 3, 2023 14:04
@che-bot
Copy link
Contributor

che-bot commented Jul 3, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Jul 3, 2023

/test v11-dashboard-happy-path

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from 3e2eaf6 to f3c6279 Compare July 4, 2023 11:23
@che-bot
Copy link
Contributor

che-bot commented Jul 4, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW ScrewTSW changed the title WIP: Implement eclipse/che Quarkus smoke test as prcheck Implement eclipse/che Quarkus smoke test as prcheck Jul 4, 2023
@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from f3c6279 to aad629e Compare July 7, 2023 10:08
@che-bot
Copy link
Contributor

che-bot commented Jul 7, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from aad629e to ea4c44a Compare July 7, 2023 10:38
@che-bot
Copy link
Contributor

che-bot commented Jul 7, 2023

Click here to review and test in web IDE: Contribute

@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from ea4c44a to 0127c31 Compare July 7, 2023 10:40
@che-bot
Copy link
Contributor

che-bot commented Jul 7, 2023

Click here to review and test in web IDE: Contribute

ScrewTSW added 3 commits July 11, 2023 11:34
Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>
Signed-off-by: Tibor Dancs (tdancs-dogfooding) <[email protected]>
@ScrewTSW ScrewTSW force-pushed the feature-implement-quarkus-smoke-test-as-prcheck branch from 0127c31 to 2e88a08 Compare July 11, 2023 11:36
@che-bot
Copy link
Contributor

che-bot commented Jul 11, 2023

Click here to review and test in web IDE: Contribute

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

@ScrewTSW: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path 2e88a08 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibuziuk
Copy link
Member

ibuziuk commented Jul 13, 2023

@olexii4 could you please take a look and follow up with @ScrewTSW on why the docker builds are failing?

@ScrewTSW
Copy link
Member Author

I'll be closing this PR in favor of the follow-up one.

@ScrewTSW ScrewTSW closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants