Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show modal for trusted repositories #1172

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Do not show modal for trusted repositories #1172

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6fa2373
fix: unexpected modal for untrusted repo
akurinnoy Aug 19, 2024
f7cf214
fix: disable the Logs and Events tabs until the workspace is created
akurinnoy Aug 21, 2024
f7ae448
chore: set dockerimage tag expiration date
akurinnoy Aug 21, 2024
92b10bf
fixup! fix: unexpected modal for untrusted repo
akurinnoy Aug 22, 2024
9be1a05
fixup! fix: disable the Logs and Events tabs until the workspace is c…
akurinnoy Aug 22, 2024
d6a5493
fix: configmap samples are trusted
akurinnoy Aug 26, 2024
b3e1d2c
fix: two browser tabs when starting a factory flow
akurinnoy Aug 27, 2024
7c38d91
fixup! fix: two browser tabs when starting a factory flow
akurinnoy Aug 27, 2024
b7824a6
fix: unexpected modal for trusted source
akurinnoy Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build/dockerfiles/skaffold.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

FROM docker.io/node:18.19.1-alpine3.19

LABEL quay.expires-after=1w
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not aware of this feature - https://docs.redhat.com/ja/documentation/red_hat_quay/3.3/html/use_red_hat_quay/tag-expiration
why do we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use this docker file to build images for testing purposes, so we don't need them to be in the registry forever.


ENV FRONTEND_LIB=../../packages/dashboard-frontend/lib/public
ENV BACKEND_LIB=../../packages/dashboard-backend/lib
ENV BACKEND_NODE_MODULES=../../packages/dashboard-backend/node_modules
Expand Down
2 changes: 1 addition & 1 deletion packages/dashboard-frontend/src/components/WorkspaceProgress/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class Progress extends React.Component<Props, State> {
doneSteps: [],
factoryParams,
initialLoaderMode,
isSourceTrustedWarningOpen: true,
isSourceTrustedWarningOpen: false,
};
}

Expand Down
7 changes: 7 additions & 0 deletions packages/dashboard-frontend/src/pages/Loader/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ export class LoaderPage extends React.PureComponent<Props, State> {
}
const showToastAlert = activeTabKey !== LoaderTab.Progress;

const isLogsTabDisabled = workspace === undefined;
const isEventsTabDisabled = workspace === undefined;

return (
<React.Fragment>
<Head pageName={pageTitle} />
Expand Down Expand Up @@ -126,6 +129,8 @@ export class LoaderPage extends React.PureComponent<Props, State> {
title={LoaderTab.Logs}
data-testid="loader-logs-tab"
id="loader-logs-tab"
isDisabled={isLogsTabDisabled}
isAriaDisabled={isLogsTabDisabled}
>
<WorkspaceLogs workspaceUID={workspace?.uid} />
</Tab>
Expand All @@ -134,6 +139,8 @@ export class LoaderPage extends React.PureComponent<Props, State> {
title={LoaderTab.Events}
data-testid="loader-events-tab"
id="loader-events-tab"
isDisabled={isEventsTabDisabled}
isAriaDisabled={isEventsTabDisabled}
>
<WorkspaceEvents workspaceUID={workspace?.uid} />
</Tab>
Expand Down
Loading