Do not show modal for trusted repositories

[akurinnoy]

What does this PR do?

This PR fixes

• the behavior of the Untrusted Repository modal, so that it doesn't reappear for already trusted repositories (see "Bug # 1);
• when switching to either the Logs or Events tab during the workspace creation phase, and staying there for a while, then the warning about the limit of running workspaces appears (see "Bug # 2"). The workaround for this bug is to disable the Logs and Events tab until the workspace is fully created;
• do not show the Untrusted Repository modal when starting an existing workspaces;
• do not show the Untrusted Repository modal when creating a workspace from the sample project on the Getting Started page.

Screenshot/screencast of this PR

Bug # 1

Screen.Recording.2024-08-21.at.13.15.53.mov

Bug # 2

Screen.Recording.2024-08-21.at.13.41.02.mov

With fixes

Screen.Recording.2024-08-21.at.13.23.35.mov

What issues does this PR fix or reference?

fixes eclipse-che/che#23097
fixes eclipse-che/che#23107
fixes eclipse-che/che#23106
fixes CRW-7139

Is it tested? How?

See the screencasts.

Release Notes

Docs PR

[che-bot]

Click here to review and test in web IDE:

[ibuziuk]

was not aware of this feature - https://docs.redhat.com/ja/documentation/red_hat_quay/3.3/html/use_red_hat_quay/tag-expiration
why do we need it?

[akurinnoy]

we use this docker file to build images for testing purposes, so we don't need them to be in the registry forever.

[ibuziuk]

great follow up PR, should be backported to 7.90.x for 3.16 cc: @dmytro-ndp @artaleks9

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1172

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1172", name: che-dashboard}]}}]"

[codecov]

Codecov Report

Attention: Patch coverage is 93.90244% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (2ae50bc) to head (b7824a6).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...-frontend/src/store/DevfileRegistries/selectors.ts	78.57%	3 Missing ⚠️
...paceProgress/CreatingSteps/Apply/Devfile/index.tsx	75.00%	1 Missing ⚠️
...ceProgress/CreatingSteps/Apply/Resources/index.tsx	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files         432      432           
  Lines       44718    44763   +45     
  Branches     3078     3095   +17     
=======================================
+ Hits        40282    40323   +41     
- Misses       4399     4402    +3     
- Partials       37       38    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1172

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1172", name: che-dashboard}]}}]"

[dmytro-ndp]

@akurinnoy : thanks for the fixup!

Validation results on Dev Spaces 3.16.0.RC + quay.io/eclipse/che-dashboard:pr-1172

1) The behavior of the Untrusted Repository modal, so that it doesn't reappear for already trusted repositories
2) when switching to either the Logs or Events tab during the workspace creation phase, and staying there for a while, then the warning about the limit of running workspaces appears (see "Bug # 2"). The workaround for this bug is to disable the Logs and Events tab until the workspace is fully created;

worked as expected:

Untrusted.Repository.modal.reappears.when.the.workspace.starts.webm

---

3) Do not show the Untrusted Repository modal when starting an existing workspaces

worked as expected:

test_start_existed_workspace.webm

---

issue eclipse-che/che#23097

couldn't reproduce

Things to address

Storing of trusted sources seems to be broken, and Untrusted Author popup appears again when create new workspace from the same factory URL after the clicking on the Continue button previously:

popup.appears.again.when.create.new.workspace.from.the.same.factory.URL.webm

---

4) do not show the Untrusted Repository modal when creating a workspace from the sample project on the Getting Started page

Need help to configure Che Dashboard to Dev Spaces specific samples in Dashboard

[olexii4]

LGTM

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1172

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1172", name: che-dashboard}]}}]"

[dmytro-ndp]

@akurinnoy : I have retested new image from this PR: quay.io/eclipse/che-dashboard@sha256:6192db43235b5f1b729e5e8ea5c72d5793d3a527abdf907e488d4ecfc1d9365a

In the updated User Dashboard the Untrusted Author popup didn't appear again when create new workspace from the same factory URL.
Well done!

I still need help with verification of the next fix:

4) do not show the Untrusted Repository modal when creating a workspace from the sample project on the Getting Started page

Provided Dev Spaces configuration didn't work.

[dmytro-ndp]

@akurinnoy : I have managed to test it with Dev Spaces 3.16.0.RC using quay.io/abazko/che-dashboard:CRW-7139 which is quay.io/eclipse/che-dashboard:pr-1172 adapted to run in Dev Spaces by @tolusha .

No issues mentioned in the description of PR have been reproduced:

che-dashboard_pull_1172_with_devspaces.webm

Well done!

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dmytro-ndp, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[akurinnoy]

@dmytro-ndp, Thank you!