Subscribe to all events in the test dApp #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages: |
|
A new deploy preview is available on Netlify at https://86d4dd4--tezostaquito.netlify.app |
ac10n
force-pushed
the
beacon-events-in-test-dapp
branch
2 times, most recently
from
00f6cab to
248842b
Compare
dsawali
reviewed
Nov 9, 2023
| @@ -29,6 +29,13 @@ export default ({ command }) => { | |||
| }/index.js` | |||
| // `../../node_modules/@airgap/beacon-dapp/dist/walletbeacon.dapp.min.js` | |||
| ), | |||
| "@airgap/beacon-sdk": path.resolve( | |||
| path.resolve(), | |||
| // "./src/walletbeacon.dapp.min.js" | |||
There was a problem hiding this comment.
are these comments needed? If not then it's probably better to clean up these artifacts
hui-an-yang
reviewed
Nov 9, 2023
| @@ -1,6 +1,5 @@ | |||
| <script lang="ts"> | |||
| import Sidebar from "./lib/Sidebar.svelte"; | |||
| import TaquitoLogo from "./lib/TaquitoLogo.svelte"; | |||
There was a problem hiding this comment.
possible to still have a static log somewhere in the background?
There was a problem hiding this comment.
I think it's OK to remove it for now. I've started a doc to improve the test dApp in notion
hui-an-yang
reviewed
Nov 9, 2023
| {#if $store.networkType === NetworkType.CUSTOM} | ||
| {shortenHash(opHash)} | ||
| {:else} | ||
| <a href={`${getTzKtUrl($store.networkType)}/${opHash}`} target="_blank" rel="noopener noreferrer"> |
There was a problem hiding this comment.
Curious of the reason to change from better-call.dev to tzkt
There was a problem hiding this comment.
AFAIK TzKt is the newer, more feature rick, more actively developed successor to BCD.
ac10n
changed the title
dsawali
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2707
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBERin the description box (when applicable)Release Note Draft Snippet
In the test dApp, all beacon events are now subscribed to and shown in the UI