Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better inclusion of events in documentation and test dApp #2707

Closed
3 tasks
ac10n opened this issue Oct 18, 2023 · 0 comments
Closed
3 tasks

Better inclusion of events in documentation and test dApp #2707

ac10n opened this issue Oct 18, 2023 · 0 comments
Assignees
Labels
beacon-test-dapp documentation Improvements or additions to documentation
Milestone

Comments

@ac10n
Copy link
Contributor

ac10n commented Oct 18, 2023

Currently, the documentation, code examples and test dApp are not using events as the primary way of reacting to changes in the wallet.

  • Include events in documents, so that people who create new dApps know the recommended way is to use events
  • Sample code should include events
  • test dApp should react to all events by logging them into the console, or better yet, include a separate div component that displays what event is currently being captured.

relevant slack conversation:
https://ecadlabs.slack.com/archives/CMX5YM1AM/p1697642427609039

@ac10n ac10n self-assigned this Oct 18, 2023
@Innkst Innkst added this to the v17.4 milestone Oct 19, 2023
@Innkst Innkst added documentation Improvements or additions to documentation beacon-test-dapp labels Oct 19, 2023
@Innkst Innkst closed this as completed Dec 1, 2023
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon-test-dapp documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

2 participants