Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration tests: don't hardcode testnet constant values (#2164) #2633

Merged
merged 1 commit into from
Aug 30, 2023
Merged

integration tests: don't hardcode testnet constant values (#2164) #2633

merged 1 commit into from
Aug 30, 2023

Conversation

dsawali
Copy link
Contributor

@dsawali dsawali commented Aug 30, 2023

@arvidj's contribution to update our integration test configs to not use hardcoded values

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@arvidj
integration tests: don't hardcode testnet constant values (#2164)
29c2eff 
* integration-tests: refactor knownContracts configuration

* integration-tests: refactor config.ts

* integration-tests: add [NetworkType] configuration parameter

This enables the distinction between 'real' test networks, such as
Jakartanet, and locally spawned sandbox networks.

* integration-tests: only run [rpc-get-protocol-constants] in testnet
@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 29c2eff
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/64ef80620406da00091fdc6e
😎 Deploy Preview https://deploy-preview-2633--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@github-actions
Copy link

A new deploy preview is available on Netlify at https://0477610--tezostaquito.netlify.app

@dsawali dsawali marked this pull request as ready for review August 30, 2023 19:42
danielelisi
danielelisi approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@danielelisi danielelisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring 👍

@dsawali dsawali merged commit f8fe773 into master Aug 30, 2023
@dsawali dsawali deleted the arvidj-integration-tests-constants branch August 30, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielelisi danielelisi danielelisi approved these changes

@ac10n ac10n ac10n approved these changes

@hui-an-yang hui-an-yang Awaiting requested review from hui-an-yang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsawali @ac10n @danielelisi @arvidj