integration tests: don't hardcode testnet constant values #2164

arvidj · 2022-11-29T12:02:38Z

This is quite a hacky solution, where the values are only checked if they match an actual RPC endpoint. This means that RPC endpoints have to be updated in two places when they change.

Another possible solution: include a key in the test configurations configuration.ts::Config like testnet: boolean or network_type: Testnet | Sandbox.

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

netlify · 2022-11-29T12:02:43Z

✅ Deploy Preview for taquito-test-dapp ready!

Name	Link
🔨 Latest commit	`046c852`
🔍 Latest deploy log	https://app.netlify.com/sites/taquito-test-dapp/deploys/6423e7f19f6053000735a0b8
😎 Deploy Preview	https://deploy-preview-2164--taquito-test-dapp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

roxaneletourneau · 2022-12-01T22:24:53Z

I am not sure about the suggested changes, because the tests can be run using a different RPC URL. The second option (network_type: Testnet | Sandbox) might be more appropriate.

arvidj · 2022-12-06T15:38:29Z

I am not sure about the suggested changes, because the tests can be run using a different RPC URL. The second option (network_type: Testnet | Sandbox) might be more appropriate.

Hi, sorry for the slow update. I've implemented what you suggested above, but I had to do some refactoring to simplify the change. What do you think?

roxaneletourneau · 2022-12-07T20:00:54Z

Thank you @arvidj !
Nice cleanup in the config.ts file.
The changes look good to me.
I replaced jakartanet with limanet (because we merged our lima branch yesterday to master).

roxaneletourneau · 2022-12-07T20:56:38Z

integration-tests/originate-known-contracts.ts

+    await setup(true);
+
+    writeOutput("import { KnownContracts } from './known-contracts';")
+    appendOutput("export const knownContracts" + protocolShort + "KnownContracts = {");


I think KnownContracts should not be part of the string.

Pushed a new version, which should fix this. The intention was to concatenate the type annotation, i.e. + ": KnownContracts" but the colon got lost. Should be fixed now.

roxaneletourneau · 2022-12-14T19:08:27Z

integration-tests/config.ts

+const limanetEphemeral: Config =
+  defaultConfig({
+    networkName: 'LIMANET',
+    protocol: Protocols.PtJakart2,


Wrong protocol hash -> should be lima, not jakarta

Fixed in the latest version.

arvidj · 2022-12-15T15:34:11Z

I've lost a commit in the rebase, hang on.

roxaneletourneau · 2022-12-16T22:03:47Z

There are failures in the flextesa jobs for the "originate-known-contracts" step:

I think these outputs are used by the "mondaynet" job, but this could be simplified by using the addresses from "https://github.com/ecadlabs/taquito/blob/master/integration-tests/known-contracts-ProtoALph.ts". Any thoughts about it @danielelisi?

danielelisi · 2022-12-16T22:29:38Z

integration-tests/originate-known-contracts.ts

+        const operation = await tezos.contract.originate(contractOriginateParams);
+        const contract = await operation.contract();
+        console.log(`known ${contractName} address:  ${contract.address}`);
+        console.log(`::set-output ${contractName}::${contract.address}\n`);


This ::set-output command needs a name parameter to fix the issue mentioned in #2164 (comment)

danielelisi · 2022-12-16T22:31:30Z

There are failures in the flextesa jobs for the "originate-known-contracts" step: I think these outputs are used by the "mondaynet" job, but this could be simplified by using the addresses from "https://github.com/ecadlabs/taquito/blob/master/integration-tests/known-contracts-ProtoALph.ts". Any thoughts about it @danielelisi?

Yes either way will work. We need to dynamically originate and pass these contract addresses to the Mondaynet integration test job because the network is reset every week.

roxaneletourneau · 2022-12-16T22:33:22Z

There are failures in the flextesa jobs for the "originate-known-contracts" step: I think these outputs are used by the "mondaynet" job, but this could be simplified by using the addresses from "https://github.com/ecadlabs/taquito/blob/master/integration-tests/known-contracts-ProtoALph.ts". Any thoughts about it @danielelisi?

Yes either way will work. We need to dynamically originate and pass these contract addresses to the Mondaynet integration test job because the network is reset every week.

Yes, we have two ways of doing the same thing, maybe we should only keep one of them.

arvidj · 2022-12-19T13:25:57Z

There are failures in the flextesa jobs for the "originate-known-contracts" step: I think these outputs are used by the "mondaynet" job, but this could be simplified by using the addresses from "https://github.com/ecadlabs/taquito/blob/master/integration-tests/known-contracts-ProtoALph.ts". Any thoughts about it @danielelisi?

Yes either way will work. We need to dynamically originate and pass these contract addresses to the Mondaynet integration test job because the network is reset every week.

Yes, we have two ways of doing the same thing, maybe we should only keep one of them.

In the latest version, I've restored the format of the ::set-output command. I now get:

> [email protected] test:originate-known-contracts
> node -r ts-node/register originate-known-contracts.ts

known contract address:  KT1WNPeBPfBjSALHBdhYgUhUAAfPDXvbAYwC
::set-output name=knownContractAddress::KT1WNPeBPfBjSALHBdhYgUhUAAfPDXvbAYwC

known bigMapContract address:  KT19bvsjNpN4KcGB5SfpSvpj8jBcCyfQH5Fm
::set-output name=knownBigMapContractAddress::KT19bvsjNpN4KcGB5SfpSvpj8jBcCyfQH5Fm

known tzip12BigMapOffChainContract address:  KT1CefqoEa95ga6SDWCUfxn2p3rVPmVJ3t1e
::set-output name=knownTzip12BigMapOffChainContractAddress::KT1CefqoEa95ga6SDWCUfxn2p3rVPmVJ3t1e

known saplingContract address:  KT1GzWFKdw7txm1fnjRuMCx913s7V8fLJ1xR
::set-output name=knownSaplingContractAddress::KT1GzWFKdw7txm1fnjRuMCx913s7V8fLJ1xR

known onChainViewContractAddress address:  KT1THQyTne7npn7vyw9WXw4oSbXpoJDY5ZHf
::set-output name=knownOnChainViewContractAddressAddress::KT1THQyTne7npn7vyw9WXw4oSbXpoJDY5ZHf

txRollupAddress:  txr1NFYQM8rkbKX9sqA4MkB6N9ifKp5zzMNZC

################################################################################

I can't validate it further though. Guess we'll have to run the flextesa tests?

I also noticed that ::set-output is deprecated: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

It doesn't seem to hard adopting to the new workflow. I could have originate-known-contracts.ts output a JSON file instead, and then read that in config.ts respectively .github/workflows/integration-tests-mondaynet.ts.

Preferably in a follow-up PR though :)

zainen · 2023-04-19T19:38:09Z

Hi @arvidj,
Just wanted to check in to see if its ok if i take over the rest of managing the pr and rebasing it. I would have to interact with your forked repo to bring it up to date for the pr

alternatively could you rebase it and we can merge into another branch that can be finalized

arvidj · 2023-04-25T08:23:58Z

Hi @arvidj, Just wanted to check in to see if its ok if i take over the rest of managing the pr and rebasing it. I would have to interact with your forked repo to bring it up to date for the pr

alternatively could you rebase it and we can merge into another branch that can be finalized

Sure, just tell me what I need to do. Sorry for the slow response.

zainen · 2023-05-15T17:06:48Z

Hi @arvidj,
Sorry for the delay! Could you rebase your pr? Then we will merge it into this branch, and then I can finalize it from here and merge it! That way, I won't need to work on your repo 😄

arvidj · 2023-07-17T12:23:08Z

Hello @arvidj if you have a moment please rebase so @zainen can merge it and finalize :)

Hi @arvidj,
Sorry for the delay! Could you rebase your pr? Then we will merge it into this branch, and then I can finalize it from here and merge it! That way, I won't need to work on your repo smile

Hi, sorry for the delay. I just pushed a rebased version.

This enables the distinction between 'real' test networks, such as Jakartanet, and locally spawned sandbox networks.

arvidj · 2023-08-30T07:55:09Z

@dsawali I just rebased, could you have a look?

) * integration-tests: refactor knownContracts configuration * integration-tests: refactor config.ts * integration-tests: add [NetworkType] configuration parameter This enables the distinction between 'real' test networks, such as Jakartanet, and locally spawned sandbox networks. * integration-tests: only run [rpc-get-protocol-constants] in testnet Co-authored-by: arvidj <[email protected]>

arvidj marked this pull request as ready for review November 29, 2022 12:35

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from 82014df to 55e4b4d Compare December 6, 2022 15:37

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from 55e4b4d to 918ac08 Compare December 7, 2022 09:19

roxaneletourneau reviewed Dec 7, 2022

View reviewed changes

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch 3 times, most recently from a36de2c to 1f0dd60 Compare December 14, 2022 18:19

roxaneletourneau requested changes Dec 14, 2022

View reviewed changes

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from 1f0dd60 to aa300d9 Compare December 14, 2022 20:42

arvidj mentioned this pull request Dec 15, 2022

Contract estimation integration tests hard codes fees #2168

Open

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from a8d5ea7 to ba33521 Compare December 15, 2022 16:37

roxaneletourneau mentioned this pull request Dec 15, 2022

Use TEZOS_NETWORK_TYPE in integration tests rather than hard-coding RPC URL #2231

Closed

8 tasks

danielelisi reviewed Dec 16, 2022

View reviewed changes

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from ba33521 to dcd2a23 Compare December 19, 2022 13:18

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from dcd2a23 to 66f5b28 Compare December 19, 2022 13:26

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from 66f5b28 to ae30caa Compare March 6, 2023 13:24

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from ae30caa to 76f3d85 Compare March 14, 2023 07:48

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from 76f3d85 to 046c852 Compare March 29, 2023 07:25

zainen changed the base branch from master to arvidj-integration-tests-constants May 15, 2023 17:05

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from 046c852 to 27befe5 Compare July 17, 2023 12:22

arvidj added 4 commits August 30, 2023 09:52

integration-tests: refactor knownContracts configuration

cb90043

integration-tests: refactor config.ts

bae6d94

integration-tests: add [NetworkType] configuration parameter

576e022

This enables the distinction between 'real' test networks, such as Jakartanet, and locally spawned sandbox networks.

integration-tests: only run [rpc-get-protocol-constants] in testnet

47d4beb

arvidj force-pushed the arvid@#2163-dont-hardcode-rpc-constants branch from 27befe5 to 47d4beb Compare August 30, 2023 07:53

dsawali merged commit 29c2eff into ecadlabs:arvidj-integration-tests-constants Aug 30, 2023

hui-an-yang mentioned this pull request Nov 21, 2023

RPC constants integration test "successfully fetches all constants for *net using ${rpc}" hard codes return values #2163

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

integration tests: don't hardcode testnet constant values #2164

integration tests: don't hardcode testnet constant values #2164

arvidj commented Nov 29, 2022

netlify bot commented Nov 29, 2022 •

edited

Loading

roxaneletourneau commented Dec 1, 2022

arvidj commented Dec 6, 2022

roxaneletourneau commented Dec 7, 2022

roxaneletourneau Dec 7, 2022

arvidj Dec 14, 2022

roxaneletourneau Dec 14, 2022

arvidj Dec 14, 2022

arvidj commented Dec 15, 2022

roxaneletourneau commented Dec 16, 2022

danielelisi Dec 16, 2022

danielelisi commented Dec 16, 2022

roxaneletourneau commented Dec 16, 2022

arvidj commented Dec 19, 2022

zainen commented Apr 19, 2023

arvidj commented Apr 25, 2023

zainen commented May 15, 2023

arvidj commented Jul 17, 2023

arvidj commented Aug 30, 2023

integration tests: don't hardcode testnet constant values #2164

integration tests: don't hardcode testnet constant values #2164

Conversation

arvidj commented Nov 29, 2022

Release Note Draft Snippet

netlify bot commented Nov 29, 2022 • edited Loading

✅ Deploy Preview for taquito-test-dapp ready!

roxaneletourneau commented Dec 1, 2022

arvidj commented Dec 6, 2022

roxaneletourneau commented Dec 7, 2022

roxaneletourneau Dec 7, 2022

Choose a reason for hiding this comment

arvidj Dec 14, 2022

Choose a reason for hiding this comment

roxaneletourneau Dec 14, 2022

Choose a reason for hiding this comment

arvidj Dec 14, 2022

Choose a reason for hiding this comment

arvidj commented Dec 15, 2022

roxaneletourneau commented Dec 16, 2022

danielelisi Dec 16, 2022

Choose a reason for hiding this comment

danielelisi commented Dec 16, 2022

roxaneletourneau commented Dec 16, 2022

arvidj commented Dec 19, 2022

zainen commented Apr 19, 2023

arvidj commented Apr 25, 2023

zainen commented May 15, 2023

arvidj commented Jul 17, 2023

arvidj commented Aug 30, 2023

netlify bot commented Nov 29, 2022 •

edited

Loading