Add proposals operation support #2112

dsawali · 2022-11-07T23:35:40Z

closes #2099

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

Your code builds cleanly without any errors or warnings
You have added unit tests
You have added integration tests (if relevant/appropriate)
All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
You have added or updated corresponding documentation
If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

netlify · 2022-11-07T23:35:49Z

✅ Deploy Preview for taquito-test-dapp canceled.

Name	Link
🔨 Latest commit	`c886464`
🔍 Latest deploy log	https://app.netlify.com/sites/taquito-test-dapp/deploys/6373e95b36834f000815940e

zainen

only one question otherwise looks good to me!

zainen · 2022-11-10T22:06:42Z

packages/taquito/test/operations/proposals-operation.spec.ts

+  it('should return proposal hash of Proposals operation', () => {
+    const op = new ProposalsOperation(
+      'ooBghN2ok5EpgEuMqYWqvfwNLBiK9eNFoPai91iwqk2nRCyUKgE',
+      { proposals: ['PtKathmankSpLLDALzWw7CGD2j2MtyveTwboEYokqUCP4a1LxMg'] } as any,


is this possible to be typed as something other than any?

that's a good question, but I suspect the reason we use any for all of the params in the test is because we might or might not pass anything at all. So any gives us the flexibility.

In general I'd stay away from the use of any as you're probably suggesting, but I think this usage in tests is probably okay.

github-actions · 2022-11-11T00:22:40Z

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

github-actions · 2022-11-11T00:27:39Z

A new deploy preview is available on Netlify at https://062f0c0--tezostaquito.netlify.app

codecov-commenter · 2022-11-11T00:28:21Z

Codecov Report

Base: 81.93% // Head: 81.98% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (c812a1d) compared to base (39b593e).
Patch coverage: 90.12% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
+ Coverage   81.93%   81.98%   +0.05%     
==========================================
  Files         214      216       +2     
  Lines       12038    12118      +80     
  Branches     2726     2745      +19     
==========================================
+ Hits         9863     9935      +72     
- Misses       2153     2161       +8     
  Partials       22       22

Impacted Files	Coverage Δ
packages/taquito-beacon-wallet/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-contracts-library/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-ledger-signer/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-local-forging/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-michel-codec/src/version.ts	`0.00% <ø> (ø)`
packages/taquito-michelson-encoder/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-remote-signer/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-rpc/src/types.ts	`100.00% <ø> (ø)`
packages/taquito-rpc/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-sapling/src/version.ts	`0.00% <ø> (ø)`
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

roxaneletourneau

Good work :)

docs/amendment_and_voting.md

packages/taquito/src/contract/rpc-contract-provider.ts

* add proposals operation * added tests for proposals operation * updated documentation to combine ballot and proposals op * remove yarn lock files * addressed PR comments and updated docs

* Re-work leading section * Compress SemVer discussion and break into sections * Incorporate feedback as solicited on hackmd.io/aYu2xvrFRbyiYtvgMpeBtw * Mk 1988 add more beacon wallet tests (#1991) * edits * more tests * added tests * test(beacon wallet): add unit tests for bacon wallet * test: fix PR * test(fix the pr): fix the PR * test(fix package problem): fix package problem * test: fix merge conflict * changes per review * add package locks * Multisig documentation (#2033) * Added documentation for multisig and reordered the doc chapters in the sidebar * Pushing uncommitted changes * Added mention of MANAGER_LAMBDA * Corrected error in text * Corrected error in doc * Corrected typo in yarn.lock file * Updated boilerplate section of the doc * Removed conflicting yarn.lock files * Updated .gitignore in /website * fix: upgrade @svgr/webpack from 6.3.1 to 6.4.0 Snyk has created this PR to upgrade @svgr/webpack from 6.3.1 to 6.4.0. See this package in npm: https://www.npmjs.com/package/@svgr/webpack See this project in Snyk: https://app.snyk.io/org/roxane/project/ad4c74dc-f97a-4a6b-8c68-4c305b03e490?utm_source=github&utm_medium=referral&page=upgrade-pr * removed tests with references to timelock feature (#2083) * 1630 ballot operation support in contract API (#2050) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * 660 support customize parser options (#2061) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * contract-security-non-existent-KT-address: use rpc (#2091) * revert changes from ballot operation * Bump @airgap/beacon-dapp to v 3.3.0 * build(deps): bump loader-utils from 1.4.0 to 1.4.1 in /packages/taquito Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump loader-utils from 1.4.0 to 1.4.1 in /website Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(releng) bump version to 14.1.0-beta-RC.0 * Commit package-lock file for taquito-test-dapp * Fix unit test related to version in ContractsLibrary * Fix unit test related to version in ContractsLibrary * Update taquito-test-dapp with taquito version 14.1.0-beta-RC.0 * chore(releng) bump version to 14.1.0 * Created version 14.1.0 on the Taquito Website * 1630 ballot (#2107) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * renamed ballotenum to BallotVote * update BallotEnum to BallotVote * Add proposals operation support (#2112) * add proposals operation * added tests for proposals operation * updated documentation to combine ballot and proposals op * remove yarn lock files * addressed PR comments and updated docs * Fix typo (repeat of "breaking changes") in Release Timing section Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Kernaghan <[email protected]> Co-authored-by: Claude Barde <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: hui-an-yang <[email protected]> Co-authored-by: Arvid Jakobsson <[email protected]> Co-authored-by: roxaneletourneau <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

dsawali added 2 commits November 7, 2022 10:42

add proposals operation

0861bb0

added tests for proposals operation

9bcd9f0

dsawali changed the title ~~2099 proposals~~ Add proposals operation support Nov 7, 2022

dsawali requested review from zainen, hui-an-yang and roxaneletourneau November 9, 2022 20:28

updated documentation to combine ballot and proposals op

6528b94

dsawali requested a review from egarson November 10, 2022 21:53

zainen approved these changes Nov 10, 2022

View reviewed changes

Merge branch 'master' of github.com:ecadlabs/taquito into 2099-proposals

c812a1d

remove yarn lock files

74be646

dsawali requested review from roxaneletourneau and removed request for roxaneletourneau November 15, 2022 18:37

roxaneletourneau reviewed Nov 15, 2022

View reviewed changes

docs/amendment_and_voting.md Outdated Show resolved Hide resolved

packages/taquito/src/contract/rpc-contract-provider.ts Outdated Show resolved Hide resolved

packages/taquito/src/contract/rpc-contract-provider.ts Outdated Show resolved Hide resolved

addressed PR comments and updated docs

c886464

dsawali requested a review from roxaneletourneau November 15, 2022 19:34

roxaneletourneau approved these changes Nov 15, 2022

View reviewed changes

dsawali merged commit 6285cee into master Nov 15, 2022

dsawali deleted the 2099-proposals branch November 15, 2022 19:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add proposals operation support #2112

Add proposals operation support #2112

dsawali commented Nov 7, 2022

netlify bot commented Nov 7, 2022 •

edited

Loading

zainen left a comment

zainen Nov 10, 2022

dsawali Nov 10, 2022

github-actions bot commented Nov 11, 2022 •

edited

Loading

github-actions bot commented Nov 11, 2022 •

edited

Loading

codecov-commenter commented Nov 11, 2022 •

edited

Loading

roxaneletourneau left a comment

Add proposals operation support #2112

Add proposals operation support #2112

Conversation

dsawali commented Nov 7, 2022

Release Note Draft Snippet

netlify bot commented Nov 7, 2022 • edited Loading

✅ Deploy Preview for taquito-test-dapp canceled.

zainen left a comment

Choose a reason for hiding this comment

zainen Nov 10, 2022

Choose a reason for hiding this comment

dsawali Nov 10, 2022

Choose a reason for hiding this comment

github-actions bot commented Nov 11, 2022 • edited Loading

Published packages:

github-actions bot commented Nov 11, 2022 • edited Loading

codecov-commenter commented Nov 11, 2022 • edited Loading

Codecov Report

roxaneletourneau left a comment

Choose a reason for hiding this comment

netlify bot commented Nov 7, 2022 •

edited

Loading

github-actions bot commented Nov 11, 2022 •

edited

Loading

github-actions bot commented Nov 11, 2022 •

edited

Loading

codecov-commenter commented Nov 11, 2022 •

edited

Loading