1630 ballot #2107

dsawali · 2022-11-07T18:49:27Z

closes #1630
Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

Your code builds cleanly without any errors or warnings
You have added unit tests
You have added integration tests (if relevant/appropriate)
All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
You have added or updated corresponding documentation
If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

netlify · 2022-11-07T18:49:33Z

✅ Deploy Preview for taquito-test-dapp canceled.

Name	Link
🔨 Latest commit	`f4c6b0c`
🔍 Latest deploy log	https://app.netlify.com/sites/taquito-test-dapp/deploys/636d5c2d55ff1400082bfd97

nicolasochem · 2022-11-09T22:34:53Z

@dsawali thank you! If you want to test this feature in a live setting, please create a PR in tezocracy to use this PR branch.

We can start a real governance cycle on kathmandunet to validate that it works end-to-end.

dsawali · 2022-11-09T22:50:14Z

@nicolasochem thanks, we'll look into that! We also have a proposals operation PR coming in. Perhaps we can test both at the same time.

github-actions · 2022-11-09T23:50:15Z

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

codecov-commenter · 2022-11-09T23:57:45Z

Codecov Report

Base: 81.93% // Head: 81.95% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (5970ecc) compared to base (20cb980).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2107      +/-   ##
==========================================
+ Coverage   81.93%   81.95%   +0.02%     
==========================================
  Files         214      215       +1     
  Lines       12038    12085      +47     
  Branches     2726     2736      +10     
==========================================
+ Hits         9863     9904      +41     
- Misses       2153     2159       +6     
  Partials       22       22

Impacted Files	Coverage Δ
packages/taquito-beacon-wallet/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-contracts-library/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-ledger-signer/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-local-forging/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-michel-codec/src/version.ts	`0.00% <ø> (ø)`
packages/taquito-michelson-encoder/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-remote-signer/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-rpc/src/types.ts	`100.00% <ø> (ø)`
packages/taquito-rpc/src/version.ts	`100.00% <ø> (ø)`
packages/taquito-sapling/src/version.ts	`0.00% <ø> (ø)`
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2022-11-09T23:58:50Z

A new deploy preview is available on Netlify at https://79aead4--tezostaquito.netlify.app

egarson · 2022-11-10T18:22:26Z

Why do we have a yarn.lock? I thought we had coalesced on npm?

dsawali · 2022-11-10T18:24:05Z

Why do we have a yarn.lock? I thought we had coalesced on npm?

@egarson It was part of legacy where we used to use yarn (before even I joined). We probably need to trim that out eventually, but it's staying in for now just in case it gets mad and breaks

zainen

just a few questions about some parts

is there a doc on how to create a proposal?

im assuming we wont have integration tests for this since it involves having the create a proposal first

packages/taquito-rpc/src/types.ts

packages/taquito/src/operations/ballot-operation.ts

packages/taquito/src/operations/operation-emitter.ts

dsawali · 2022-11-10T19:31:15Z

just a few questions about some parts

is there a doc on how to create a proposal?

im assuming we wont have integration tests for this since it involves having the create a proposal first

@zainen there's this document on amendment and voting: https://tezos.gitlab.io/lima/voting.html?highlight=amendment%20voting

but if you're talking about to create a proposal in Taquito, it will be part of the next PR.

And yes, the integration test will be written after this PR and another one gets merged

zainen

LGTM :D

* added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * renamed ballotenum to BallotVote * update BallotEnum to BallotVote

* Re-work leading section * Compress SemVer discussion and break into sections * Incorporate feedback as solicited on hackmd.io/aYu2xvrFRbyiYtvgMpeBtw * Mk 1988 add more beacon wallet tests (#1991) * edits * more tests * added tests * test(beacon wallet): add unit tests for bacon wallet * test: fix PR * test(fix the pr): fix the PR * test(fix package problem): fix package problem * test: fix merge conflict * changes per review * add package locks * Multisig documentation (#2033) * Added documentation for multisig and reordered the doc chapters in the sidebar * Pushing uncommitted changes * Added mention of MANAGER_LAMBDA * Corrected error in text * Corrected error in doc * Corrected typo in yarn.lock file * Updated boilerplate section of the doc * Removed conflicting yarn.lock files * Updated .gitignore in /website * fix: upgrade @svgr/webpack from 6.3.1 to 6.4.0 Snyk has created this PR to upgrade @svgr/webpack from 6.3.1 to 6.4.0. See this package in npm: https://www.npmjs.com/package/@svgr/webpack See this project in Snyk: https://app.snyk.io/org/roxane/project/ad4c74dc-f97a-4a6b-8c68-4c305b03e490?utm_source=github&utm_medium=referral&page=upgrade-pr * removed tests with references to timelock feature (#2083) * 1630 ballot operation support in contract API (#2050) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * 660 support customize parser options (#2061) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * contract-security-non-existent-KT-address: use rpc (#2091) * revert changes from ballot operation * Bump @airgap/beacon-dapp to v 3.3.0 * build(deps): bump loader-utils from 1.4.0 to 1.4.1 in /packages/taquito Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump loader-utils from 1.4.0 to 1.4.1 in /website Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(releng) bump version to 14.1.0-beta-RC.0 * Commit package-lock file for taquito-test-dapp * Fix unit test related to version in ContractsLibrary * Fix unit test related to version in ContractsLibrary * Update taquito-test-dapp with taquito version 14.1.0-beta-RC.0 * chore(releng) bump version to 14.1.0 * Created version 14.1.0 on the Taquito Website * 1630 ballot (#2107) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * renamed ballotenum to BallotVote * update BallotEnum to BallotVote * Add proposals operation support (#2112) * add proposals operation * added tests for proposals operation * updated documentation to combine ballot and proposals op * remove yarn lock files * addressed PR comments and updated docs * Fix typo (repeat of "breaking changes") in Release Timing section Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Kernaghan <[email protected]> Co-authored-by: Claude Barde <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: hui-an-yang <[email protected]> Co-authored-by: Arvid Jakobsson <[email protected]> Co-authored-by: roxaneletourneau <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

dsawali added 12 commits October 17, 2022 17:16

added estimate and contract ballot operation support

e2f5188

added rpc contract provider for ballot op

209464f

updated implementation and added docs

6e711dc

resolve merge conflicts

3bb1924

added property in OperationContentsAndResultBallot and added unit test

9027764

remove metadata property from ballot

4c2e0c8

addressed PR comments

f314514

updated yarn and package-lock

c455fff

resolve merge conflicts

65f3440

cleaned up comments and switched out async for promise in op emitter

b49f32c

solve merge conflicts

5b7c629

removed unnecessary line break

6aee5ab

dsawali requested review from roxaneletourneau, zainen and hui-an-yang November 9, 2022 23:37

resolved merge conflict

5970ecc

dsawali requested a review from egarson November 10, 2022 17:58

zainen reviewed Nov 10, 2022

View reviewed changes

zainen approved these changes Nov 10, 2022

View reviewed changes

dsawali added 2 commits November 10, 2022 11:39

renamed ballotenum to BallotVote

074f60a

update BallotEnum to BallotVote

f4c6b0c

dsawali merged commit 2d08306 into master Nov 10, 2022

dsawali deleted the 1630-ballot branch November 10, 2022 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1630 ballot #2107

1630 ballot #2107

dsawali commented Nov 7, 2022

netlify bot commented Nov 7, 2022 •

edited

Loading

nicolasochem commented Nov 9, 2022

dsawali commented Nov 9, 2022

github-actions bot commented Nov 9, 2022 •

edited

Loading

codecov-commenter commented Nov 9, 2022 •

edited

Loading

github-actions bot commented Nov 9, 2022 •

edited

Loading

egarson commented Nov 10, 2022

dsawali commented Nov 10, 2022

zainen left a comment

dsawali commented Nov 10, 2022

zainen left a comment

1630 ballot #2107

1630 ballot #2107

Conversation

dsawali commented Nov 7, 2022

Release Note Draft Snippet

netlify bot commented Nov 7, 2022 • edited Loading

✅ Deploy Preview for taquito-test-dapp canceled.

nicolasochem commented Nov 9, 2022

dsawali commented Nov 9, 2022

github-actions bot commented Nov 9, 2022 • edited Loading

Published packages:

codecov-commenter commented Nov 9, 2022 • edited Loading

Codecov Report

github-actions bot commented Nov 9, 2022 • edited Loading

egarson commented Nov 10, 2022

dsawali commented Nov 10, 2022

zainen left a comment

Choose a reason for hiding this comment

dsawali commented Nov 10, 2022

zainen left a comment

Choose a reason for hiding this comment

netlify bot commented Nov 7, 2022 •

edited

Loading

github-actions bot commented Nov 9, 2022 •

edited

Loading

codecov-commenter commented Nov 9, 2022 •

edited

Loading

github-actions bot commented Nov 9, 2022 •

edited

Loading