Full Nova 4 compatibility #317
Conversation
|
@mucenica-bogdan can you squash your commits please? |
mucenica-bogdan
force-pushed
the
nova-4-compatibility
branch
from
0ec77d7 to
caa30d6
Compare
|
@bkintanar - sure thing, squash done. |
|
Can you add notes in the Readme with regards to the vue clipper being replaced?
…--
Bertrand Kintanar
***@***.***
On Apr 18, 2022, 1:30 PM +0800, Bogdan Mucenica ***@***.***>, wrote:
@bkintanar - sure thing, squash done.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Sure thing, I'll add in the release notes. Thinking of the wording for this, made me release that this new vue3 patch will break compatibility with nova <= v3. How do plan to release this? New major version maybe, v4.0? If so than we can update the readme to point people to the right version of What do you think? |
mucenica-bogdan
force-pushed
the
nova-4-compatibility
branch
from
caa30d6 to
67203bf
Compare
- update composer deps for min nova v4 - fix v-model - fix cropper - fix custom properties - draggable fix - fix existing media - prod build - update readme
mucenica-bogdan
force-pushed
the
nova-4-compatibility
branch
from
67203bf to
d349609
Compare
|
@bkintanar - if you go with a major version update approach (to v4), I've already pushed in a |
|
Thank you I will take a look at it once I am on the computer.
…--
Bertrand Kintanar
***@***.***
On Apr 18, 2022, 8:42 PM +0800, Bogdan Mucenica ***@***.***>, wrote:
@bkintanar - if you go with a major version update approach (to v4), I've already pushed in a change log section to readme. see https://github.com/ebess/advanced-nova-media-library/blob/d34960995e7522d309c8dc5bfc4b7eacf47a357a/readme.md#change-log
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
any update on this? |
|
Will do a release later today.
…On Apr 20, 2022, 10:39 AM +0800, Darlington ***@***.***>, wrote:
any update on this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
we are waiting for it =) |
|
Thanks everyone! Now where's the beer tap? |
|
@mucenica-bogdan, @SupchickCode can anyone of you test the latest release and report back please? |
|
@bkintanar - i have some time for this tonight, I'll give it a test. |
|
Thanks @mucenica-bogdan. The reason I'm asking is that because I currently don't run Nova 4 in any of my projects so I can't really test atm. Thank you for the PR @mucenica-bogdan |
|
The PR looks good after I tested it on my local. However, for viewing the file within the details page it says
|
|
@mucenica-bogdan, when you do your own testing tonight, can you take a look on that single file issue @harlekoy posted? |
|
Will definitely have a look tonight. |
|
@bkintanar - created a PR for a bugfix patch: #321 also, this PR might not be relevant any longer: #315 |
Co-authored-by: Bogdan Mucenica <[email protected]>
vue-advanced-cropper, I replaced the slider with two buttons to rotate by 90degs in either way.tailwindcssv3From my tests everything works fine. The only things I haven't test is the Vapor integration.