-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{phys}[intel/2019b] BLOCK v1.5.3 w/ Python 2.7.16 #16642
{phys}[intel/2019b] BLOCK v1.5.3 w/ Python 2.7.16 #16642
Conversation
Test report by @nicholascheng94 |
@nicholascheng94: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/3467443012
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
|
||
dependencies = [ | ||
('Python', '2.7.16'), | ||
('Boost', '1.55.0', versionsuffix), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our repository of easyconfigs restricts the versions allow for each dependency to one per toolchain. This is necessary to keep the size of our repository in check.
In this case, this means that all easyconfigs in intel/2019b
depending on Boost
can only depend on v1.71.0 of Boost. Please update this dependency accordingly.
('Boost', '1.55.0', versionsuffix), | |
('Boost', '1.71.0', versionsuffix), |
@@ -0,0 +1,94 @@ | |||
--- input.h.orig 2020-05-13 14:26:17.364524313 +0800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a header to the patch file describing its purpose and author.
toolchainopts = {'cstd': 'c++11'} | ||
|
||
sources = [SOURCELOWER_TAR_GZ] | ||
source_urls = ['http://www.sunqm.net/pyscf/files/src/'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is necessary to add the checksums of all sources and files. You can do so with the command eb --inject-checksums
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicholascheng94 I've been also working on Block v1.5.3 as well, but in a more recent toolchain. See #16711.
I made a PR to your fork with my suggested changes. Please check nicholascheng94#1 and, if you agree with the changes, merge it to automatically update this PR.
This is the list changes compared to your easyconfig:
- use sources from new repo in https://github.com/pyscf/Block
- add missing checksums (with
eb --inject-checksums
) - use Python only as
builddependency
(it is not needed to executeblock.spin_adapted
) - use version of Boost provided in this toolchain (see {phys}[intel/2019b] BLOCK v1.5.3 w/ Python 2.7.16 #16642 (comment))
- build both the MPI and serial versions of Boost
- add sanity check commands
rename BLOCK to Block and update with latest sources for v1.5.3
@nicholascheng94: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/4934117301
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
Thanks @lexming ! So sorry for the delay... was not working on using this software anymore so had not the time to get back on this. |
Closing this since We have an easyconfig for Block with a more recent toolchain, see #19493 |
(created using
eb --new-pr
)