Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 ⬆️ 🚸 Upgrade android to API 33 #1019

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

shankari
Copy link
Contributor

@shankari shankari commented Aug 22, 2023

⬆️ Upgrade android to API 33
🔧 build script updates
🚸 permission usability updates

Merging over from #1016

- Support building individual platforms with the prod JS but dev native code
    - This will allow us to test the prod JS by connecting with a debugger (if needed)
    - Also allows quicker dev cycle by building only one platform at a time
      (note that for testing outside the devapp, we need to build the app every time)
    - Ensures that we don't need to get off the VPN just to build iOS
        - Ensures that we can build prod JS iOS version for archival and submission
- Support building android with the prod JS and prod native code
    - To support building the aab to upload to the play store

Testing done:
- Used for building the NREL OpenPATH app
So that we use webpack for the javascript properly

Testing done:
- Used to build the NREL OpenPATH app
So that we can archive it to check out old functionality if needed
- `cordova-android` to 12
- `cordova-plugin-file` to 8.0.0
- Remove SDK version overrides and go with the cordova-android defaults

Note that this will not work until
e-mission/e-mission-data-collection#207
is merged

#1016 (comment)
Everything should compile now.
We can check in the sdk changes independently; the main goal is to start
testing these changes before the release.
🔧 ⬆️ 🚸 Upgrade android to API 33
@shankari shankari merged commit b13fd3f into aria_and_fall_2023_rewrite Aug 22, 2023
@shankari shankari deleted the maint_upgrade_2023 branch September 4, 2023 23:59
@shankari shankari restored the maint_upgrade_2023 branch September 4, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant