⬆️ 🔥 Upgrade to API 33 (remove workaround) #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In android 10, the cordova team removed support for `compileSdkVersion` However, in order to support auto-reset of permissions, we needed to use a later SDK than the target. After filing an issue in the cordova-android repo, we added this grade file as a workaround. However, they have now reintroduced it in android 11 apache/cordova-android#1373 (comment) *and* our compile and target SDKs have caught up anyway So we can remove the workaround. More detail at: e-mission/e-mission-phone#1016 (comment)
shankari
added a commit
to shankari/e-mission-phone
that referenced
this pull request
Aug 19, 2023
- `cordova-android` to 12 - `cordova-plugin-file` to 8.0.0 - Remove SDK version overrides and go with the cordova-android defaults Note that this will not work until e-mission/e-mission-data-collection#207 is merged e-mission#1016 (comment)
We are not going to include the change to the optimization popup for now, so I am going to bump up this version and declare this release as done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In android 10, the cordova team removed support for
compileSdkVersionHowever, in order to support auto-reset of permissions, we needed to use a later SDK than the target.After filing an issue in the cordova-android repo, we added this grade file as a workaround. However, they have now reintroduced it in android 11 apache/cordova-android#1373 (comment) and our compile and target SDKs have caught up anyway
So we can remove the workaround.
More detail at:
e-mission/e-mission-phone#1016 (comment)